Skip to content

Link to pull request within mail points to external issue tracker #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
otbutz opened this issue Jan 13, 2021 · 1 comment
Closed
2 of 6 tasks

Link to pull request within mail points to external issue tracker #14326

otbutz opened this issue Jan 13, 2021 · 1 comment
Labels
issue/duplicate The issue has already been reported. type/bug

Comments

@otbutz
Copy link

otbutz commented Jan 13, 2021

  • Gitea version (or commit ref): 1.13.1

  • Git version: 2.30

  • Operating system: Ubuntu 20.04

  • Database:

    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:

    • Yes (provide example URL)
    • No

Description

I've enabled mail notifications for our repository and also configured an external issue tracker. Everything seems to work except for the URLs of PR references by number in the mail notifications.

Example:

Requested to review #3507.

---
View it on Gitea: Git with a cup of tea.

The link behind #3507 is wrong as it points to our issue tracker:

<p>Requested to review <a href="https://redmine.example.com/issues/3507" rel="nofollow nofollow noopener noreferrer" target="_blank">#3507</a>.</p>

I'd expect gitea to link to the PR page which would have the following URL:

https://git.example.com/myorg/myrepo/pulls/3507

The other URL at the bottom is correct though:

<a href="https://git.example.com/myorg/myrepo/pulls/3507#issuecomment-32580" target="_blank" rel="nofollow noopener noreferrer">View it on Gitea: Git with a cup of tea</a>.</p>
@otbutz otbutz changed the title Links to pull request within mail points to external issue tracker Link to pull request within mail points to external issue tracker Jan 13, 2021
@lunny lunny added the type/bug label Jan 13, 2021
@jpraet
Copy link
Member

jpraet commented Jan 13, 2021

Duplicate of #13720 (already fixed in 1.14).

@lunny lunny closed this as completed Jan 13, 2021
@lunny lunny added the issue/duplicate The issue has already been reported. label Jan 13, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported. type/bug
Projects
None yet
Development

No branches or pull requests

3 participants