Skip to content

Emoji alias not parsed in links #12331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 7 tasks
rodolpheh opened this issue Jul 26, 2020 · 3 comments · Fixed by #16221
Closed
2 of 7 tasks

Emoji alias not parsed in links #12331

rodolpheh opened this issue Jul 26, 2020 · 3 comments · Fixed by #16221
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@rodolpheh
Copy link

rodolpheh commented Jul 26, 2020

Description

When using an emoji alias in an inline link, it is not displayed as an emoji but keeps its alias. The test page created shows the result of emoji alias in most cases. The inline link does not show an emoji but its alias.

Screenshots

image

@mrsdizzie
Copy link
Member

Our renderers intentionally ignore existing links for modifying text so you would need to just use the real character you want instead of an alias. If it is something being created through an issue/wiki editor on our site it should give a dropdown menu to insert the real character if typing out an alias.

https://github.com/go-gitea/gitea/blob/master/modules/markup/html.go#L357

@silverwind
Copy link
Member

Pushed that repo to GH, it seems they do render emoji tokens in links. Otherwise, output seems to match ours:

https://github.com/silverwind/emoji-markdown-tests

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Oct 4, 2020
@stale stale bot removed the issue/stale label Oct 4, 2020
@zeripath zeripath added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/stale labels Oct 4, 2020
@stale stale bot removed the issue/stale label Oct 4, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants