Skip to content

Use SVG for own usage of FontAwesome #12162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind opened this issue Jul 6, 2020 · 2 comments
Closed

Use SVG for own usage of FontAwesome #12162

silverwind opened this issue Jul 6, 2020 · 2 comments
Labels
issue/stale type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@silverwind
Copy link
Member

silverwind commented Jul 6, 2020

We have the FontAwesome icon font in use for a couple of icons and Fomantic-UI ships a custom version of it in their icon font. We can't change the usage in Fomantic-UI but we can replace our own usage with SVG using the files provided in https://www.npmjs.com/package/@fortawesome/fontawesome-free.

Maybe it's even an option to switch to Octicons completely, I think overall it's just 20 or so icons we use from FontAwesome.

Depends on #12157.

@lafriks lafriks added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 6, 2020
@stale
Copy link

stale bot commented Sep 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Sep 5, 2020
@silverwind
Copy link
Member Author

silverwind commented Sep 7, 2020

I consider gradually switching everything to Octicons as the solution here.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/stale type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants