Issue number will not be updated by closing an issue

[luwol03]

• Gitea version (or commit ref): 99082ee
• Git version: 2.20.1
• Operating system: Linux Debian buster
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

If I automatically close issues via a reference in a pull request, the issue will be closed, but the number next to the issues tab will not be updated! Only if I restart gitea!

[jolheiser]

Are there any errors in the logs? I cannot reproduce this on try with the latest commit.

Admittedly try uses SQLite, so this could be specific to MySQL, but I'm not sure why that would be.

[luwol03]

Where I can find the log?

[jolheiser]

Seems I spoke too soon.

Closing an issue from the PR description works, however when I closed the issue via a commit the number didn't change. (In both cases the issue closed, but in the latter it didn't update the number)
https://try.gitea.io/jolheiser/ciw/issues

[silverwind]

Duplicate of #10536

[zeripath]

So eventually when a commit is parsed that closes an issue we reach:

gitea/modules/repofiles/action.go

Lines 61 to 149 in a1f11a0

	// UpdateIssuesCommit checks if issues are manipulated by commit message.
	func UpdateIssuesCommit(doer *models.User, repo *models.Repository, commits []*repository.PushCommit, branchName string) error {
	// Commits are appended in the reverse order.
	for i := len(commits) - 1; i >= 0; i-- {
	c := commits[i]
	type markKey struct {
	ID int64
	Action references.XRefAction
	}
	refMarked := make(map[markKey]bool)
	var refRepo *models.Repository
	var refIssue *models.Issue
	var err error
	for _, ref := range references.FindAllIssueReferences(c.Message) {
	// issue is from another repo
	if len(ref.Owner) > 0 && len(ref.Name) > 0 {
	refRepo, err = models.GetRepositoryFromMatch(ref.Owner, ref.Name)
	if err != nil {
	continue
	}
	} else {
	refRepo = repo
	}
	if refIssue, err = getIssueFromRef(refRepo, ref.Index); err != nil {
	return err
	}
	if refIssue == nil {
	continue
	}
	perm, err := models.GetUserRepoPermission(refRepo, doer)
	if err != nil {
	return err
	}
	key := markKey{ID: refIssue.ID, Action: ref.Action}
	if refMarked[key] {
	continue
	}
	refMarked[key] = true
	// FIXME: this kind of condition is all over the code, it should be consolidated in a single place
	canclose := perm.IsAdmin() || perm.IsOwner() || perm.CanWriteIssuesOrPulls(refIssue.IsPull) || refIssue.PosterID == doer.ID
	cancomment := canclose || perm.CanReadIssuesOrPulls(refIssue.IsPull)
	// Don't proceed if the user can't comment
	if !cancomment {
	continue
	}
	message := fmt.Sprintf(`<a href="%s/commit/%s">%s</a>`, repo.Link(), c.Sha1, html.EscapeString(c.Message))
	if err = models.CreateRefComment(doer, refRepo, refIssue, message, c.Sha1); err != nil {
	return err
	}
	// Only issues can be closed/reopened this way, and user needs the correct permissions
	if refIssue.IsPull || !canclose {
	continue
	}
	// Only process closing/reopening keywords
	if ref.Action != references.XRefActionCloses && ref.Action != references.XRefActionReopens {
	continue
	}
	if !repo.CloseIssuesViaCommitInAnyBranch {
	// If the issue was specified to be in a particular branch, don't allow commits in other branches to close it
	if refIssue.Ref != "" {
	if branchName != refIssue.Ref {
	continue
	}
	// Otherwise, only process commits to the default branch
	} else if branchName != repo.DefaultBranch {
	continue
	}
	}
	close := (ref.Action == references.XRefActionCloses)
	if close != refIssue.IsClosed {
	if err := changeIssueStatus(refRepo, refIssue, doer, close); err != nil {
	return err
	}
	}
	}
	}
	return nil
	}

This calls

gitea/modules/repofiles/action.go

Lines 34 to 49 in a1f11a0

	func changeIssueStatus(repo *models.Repository, issue *models.Issue, doer *models.User, closed bool) error {
	stopTimerIfAvailable := func(doer *models.User, issue *models.Issue) error {
	if models.StopwatchExists(doer.ID, issue.ID) {
	if err := models.CreateOrStopIssueStopwatch(doer, issue); err != nil {
	return err
	}
	}
	return nil
	}
	issue.Repo = repo
	comment, err := issue.ChangeStatus(doer, closed)
	if err != nil {
	// Don't return an error when dependencies are open as this would let the push fail

Which calls issue.ChangeStatus like all the other routes

[zeripath]

issue.ChangeStatus calls issue.changeStatus which does call:

gitea/models/issue.go

Line 622 in a1f11a0

if err := issue.updateClosedNum(e); err != nil {

which attempts to update the row - but I suspect is not because the value is not being looked up from within the changed table.

The thing that all the other routes do is that they add a comment after the changestatus - not before - which will look at the committed changes to the issue table.

[zeripath]

The simplest solution is to move the createRefComment to after the attempt to close the issue.

This is also more correct as the comment should not be made until the issue is actually closed.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.