Fix improper HTMLURL usages in Go code (#22839)

wxiaoguang · lunny · web-flow · commit e9288c247731 · 2023-02-11T14:34:11.000+08:00
In Go code, HTMLURL should be only used for external systems, like
API/webhook/mail/notification, etc.

If a URL is used by `Redirect` or rendered in a template, it should be a
relative URL (aka `Link()` in Gitea)

Co-authored-by: Lunny Xiao &lt;xiaolunwen@gmail.com&gt;
diff --git a/models/repo/repo.go b/models/repo/repo.go
@@ -274,7 +274,7 @@ func (repo *Repository) CommitLink(commitID string) (result string) {
 	if commitID == "" || commitID == "0000000000000000000000000000000000000000" {
 		result = ""
 	} else {
-		result = repo.HTMLURL() + "/commit/" + url.PathEscape(commitID)
+		result = repo.Link() + "/commit/" + url.PathEscape(commitID)
 	}
 	return result
 }
diff --git a/modules/context/repo.go b/modules/context/repo.go
@@ -743,9 +743,9 @@ func RepoAssignment(ctx *Context) (cancel context.CancelFunc) {
 
 	if ctx.FormString("go-get") == "1" {
 		ctx.Data["GoGetImport"] = ComposeGoGetImport(owner.Name, repo.Name)
-		prefix := repo.HTMLURL() + "/src/branch/" + util.PathEscapeSegments(ctx.Repo.BranchName)
-		ctx.Data["GoDocDirectory"] = prefix + "{/dir}"
-		ctx.Data["GoDocFile"] = prefix + "{/dir}/{file}#L{line}"
+		fullURLPrefix := repo.HTMLURL() + "/src/branch/" + util.PathEscapeSegments(ctx.Repo.BranchName)
+		ctx.Data["GoDocDirectory"] = fullURLPrefix + "{/dir}"
+		ctx.Data["GoDocFile"] = fullURLPrefix + "{/dir}/{file}#L{line}"
 	}
 	return cancel
 }
diff --git a/routers/web/repo/actions/actions.go b/routers/web/repo/actions/actions.go
@@ -70,7 +70,7 @@ func List(ctx *context.Context) {
 	}
 
 	ctx.Data["workflows"] = workflows
-	ctx.Data["RepoLink"] = ctx.Repo.Repository.HTMLURL()
+	ctx.Data["RepoLink"] = ctx.Repo.Repository.Link()
 
 	page := ctx.FormInt("page")
 	if page <= 0 {
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go
@@ -100,7 +100,7 @@ func MustAllowUserComment(ctx *context.Context) {
 
 	if issue.IsLocked && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) && !ctx.Doer.IsAdmin {
 		ctx.Flash.Error(ctx.Tr("repo.issues.comment_on_locked"))
-		ctx.Redirect(issue.HTMLURL())
+		ctx.Redirect(issue.Link())
 		return
 	}
 }
@@ -927,7 +927,7 @@ func NewIssueChooseTemplate(ctx *context.Context) {
 
 	if len(issueTemplates) == 0 {
 		// The "issues/new" and "issues/new/choose" share the same query parameters "project" and "milestone", if no template here, just redirect to the "issues/new" page with these parameters.
-		ctx.Redirect(fmt.Sprintf("%s/issues/new?%s", ctx.Repo.Repository.HTMLURL(), ctx.Req.URL.RawQuery), http.StatusSeeOther)
+		ctx.Redirect(fmt.Sprintf("%s/issues/new?%s", ctx.Repo.Repository.Link(), ctx.Req.URL.RawQuery), http.StatusSeeOther)
 		return
 	}
 
@@ -950,11 +950,11 @@ func DeleteIssue(ctx *context.Context) {
 	}
 
 	if issue.IsPull {
-		ctx.Redirect(fmt.Sprintf("%s/pulls", ctx.Repo.Repository.HTMLURL()), http.StatusSeeOther)
+		ctx.Redirect(fmt.Sprintf("%s/pulls", ctx.Repo.Repository.Link()), http.StatusSeeOther)
 		return
 	}
 
-	ctx.Redirect(fmt.Sprintf("%s/issues", ctx.Repo.Repository.HTMLURL()), http.StatusSeeOther)
+	ctx.Redirect(fmt.Sprintf("%s/issues", ctx.Repo.Repository.Link()), http.StatusSeeOther)
 }
 
 // ValidateRepoMetas check and returns repository's meta information
@@ -1425,7 +1425,7 @@ func ViewIssue(ctx *context.Context) {
 						return
 					}
 					// Add link to the issue of the already running stopwatch
-					ctx.Data["OtherStopwatchURL"] = otherIssue.HTMLURL()
+					ctx.Data["OtherStopwatchURL"] = otherIssue.Link()
 				}
 			}
 			ctx.Data["CanUseTimetracker"] = ctx.Repo.CanUseTimetracker(issue, ctx.Doer)
@@ -2658,7 +2658,7 @@ func NewComment(ctx *context.Context) {
 
 	if issue.IsLocked && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) && !ctx.Doer.IsAdmin {
 		ctx.Flash.Error(ctx.Tr("repo.issues.comment_on_locked"))
-		ctx.Redirect(issue.HTMLURL())
+		ctx.Redirect(issue.Link())
 		return
 	}
 
@@ -2669,7 +2669,7 @@ func NewComment(ctx *context.Context) {
 
 	if ctx.HasError() {
 		ctx.Flash.Error(ctx.Data["ErrorMsg"].(string))
-		ctx.Redirect(issue.HTMLURL())
+		ctx.Redirect(issue.Link())
 		return
 	}
 
diff --git a/routers/web/repo/issue_dependency.go b/routers/web/repo/issue_dependency.go
@@ -34,7 +34,7 @@ func AddDependency(ctx *context.Context) {
 	}
 
 	// Redirect
-	defer ctx.Redirect(issue.HTMLURL())
+	defer ctx.Redirect(issue.Link())
 
 	// Dependency
 	dep, err := issues_model.GetIssueByID(ctx, depID)
@@ -124,5 +124,5 @@ func RemoveDependency(ctx *context.Context) {
 	}
 
 	// Redirect
-	ctx.Redirect(issue.HTMLURL())
+	ctx.Redirect(issue.Link())
 }
diff --git a/routers/web/repo/issue_lock.go b/routers/web/repo/issue_lock.go
@@ -21,13 +21,13 @@ func LockIssue(ctx *context.Context) {
 
 	if issue.IsLocked {
 		ctx.Flash.Error(ctx.Tr("repo.issues.lock_duplicate"))
-		ctx.Redirect(issue.HTMLURL())
+		ctx.Redirect(issue.Link())
 		return
 	}
 
 	if !form.HasValidReason() {
 		ctx.Flash.Error(ctx.Tr("repo.issues.lock.unknown_reason"))
-		ctx.Redirect(issue.HTMLURL())
+		ctx.Redirect(issue.Link())
 		return
 	}
 
@@ -40,7 +40,7 @@ func LockIssue(ctx *context.Context) {
 		return
 	}
 
-	ctx.Redirect(issue.HTMLURL())
+	ctx.Redirect(issue.Link())
 }
 
 // UnlockIssue unlocks a previously locked issue.
@@ -52,7 +52,7 @@ func UnlockIssue(ctx *context.Context) {
 
 	if !issue.IsLocked {
 		ctx.Flash.Error(ctx.Tr("repo.issues.unlock_error"))
-		ctx.Redirect(issue.HTMLURL())
+		ctx.Redirect(issue.Link())
 		return
 	}
 
@@ -64,5 +64,5 @@ func UnlockIssue(ctx *context.Context) {
 		return
 	}
 
-	ctx.Redirect(issue.HTMLURL())
+	ctx.Redirect(issue.Link())
 }
diff --git a/routers/web/repo/issue_stopwatch.go b/routers/web/repo/issue_stopwatch.go
@@ -40,7 +40,7 @@ func IssueStopwatch(c *context.Context) {
 		c.Flash.Success(c.Tr("repo.issues.tracker_auto_close"))
 	}
 
-	url := issue.HTMLURL()
+	url := issue.Link()
 	c.Redirect(url, http.StatusSeeOther)
 }
 
@@ -72,7 +72,7 @@ func CancelStopwatch(c *context.Context) {
 		})
 	}
 
-	url := issue.HTMLURL()
+	url := issue.Link()
 	c.Redirect(url, http.StatusSeeOther)
 }
 
diff --git a/routers/web/repo/issue_timetrack.go b/routers/web/repo/issue_timetrack.go
@@ -26,7 +26,7 @@ func AddTimeManually(c *context.Context) {
 		c.NotFound("CanUseTimetracker", nil)
 		return
 	}
-	url := issue.HTMLURL()
+	url := issue.Link()
 
 	if c.HasError() {
 		c.Flash.Error(c.GetErrMsg())
@@ -83,5 +83,5 @@ func DeleteTime(c *context.Context) {
 	}
 
 	c.Flash.Success(c.Tr("repo.issues.del_time_history", util.SecToTime(t.Time)))
-	c.Redirect(issue.HTMLURL())
+	c.Redirect(issue.Link())
 }
diff --git a/routers/web/repo/issue_watch.go b/routers/web/repo/issue_watch.go
@@ -52,5 +52,5 @@ func IssueWatch(ctx *context.Context) {
 		return
 	}
 
-	ctx.Redirect(issue.HTMLURL())
+	ctx.Redirect(issue.Link())
 }
diff --git a/routers/web/repo/pull_review.go b/routers/web/repo/pull_review.go
@@ -98,7 +98,7 @@ func CreateCodeComment(ctx *context.Context) {
 		renderConversation(ctx, comment)
 		return
 	}
-	ctx.Redirect(comment.HTMLURL())
+	ctx.Redirect(comment.Link())
 }
 
 // UpdateResolveConversation add or remove an Conversation resolved mark
diff --git a/routers/web/repo/release.go b/routers/web/repo/release.go
@@ -295,7 +295,7 @@ func LatestRelease(ctx *context.Context) {
 		return
 	}
 
-	ctx.Redirect(release.HTMLURL())
+	ctx.Redirect(release.Link())
 }
 
 // NewRelease render creating or edit release page
diff --git a/routers/web/repo/repo.go b/routers/web/repo/repo.go
@@ -344,7 +344,7 @@ func acceptOrRejectRepoTransfer(ctx *context.Context, accept bool) error {
 		ctx.Flash.Success(ctx.Tr("repo.settings.transfer.rejected"))
 	}
 
-	ctx.Redirect(ctx.Repo.Repository.HTMLURL())
+	ctx.Redirect(ctx.Repo.Repository.Link())
 	return nil
 }
 
diff --git a/routers/web/repo/search.go b/routers/web/repo/search.go
@@ -54,7 +54,7 @@ func Search(ctx *context.Context) {
 		ctx.Data["CodeIndexerUnavailable"] = !code_indexer.IsAvailable()
 	}
 
-	ctx.Data["SourcePath"] = ctx.Repo.Repository.HTMLURL()
+	ctx.Data["SourcePath"] = ctx.Repo.Repository.Link()
 	ctx.Data["SearchResults"] = searchResults
 	ctx.Data["SearchResultLanguages"] = searchResultLanguages
 
diff --git a/routers/web/repo/view.go b/routers/web/repo/view.go
@@ -318,7 +318,7 @@ func renderReadmeFile(ctx *context.Context, readmeFile *namedBlob, readmeTreelin
 
 	if fInfo.isLFSFile {
 		filenameBase64 := base64.RawURLEncoding.EncodeToString([]byte(readmeFile.name))
-		ctx.Data["RawFileLink"] = fmt.Sprintf("%s.git/info/lfs/objects/%s/%s", ctx.Repo.Repository.HTMLURL(), url.PathEscape(fInfo.lfsMeta.Oid), url.PathEscape(filenameBase64))
+		ctx.Data["RawFileLink"] = fmt.Sprintf("%s.git/info/lfs/objects/%s/%s", ctx.Repo.Repository.Link(), url.PathEscape(fInfo.lfsMeta.Oid), url.PathEscape(filenameBase64))
 	}
 
 	if !fInfo.isTextFile {
@@ -738,7 +738,7 @@ func Home(ctx *context.Context) {
 		}
 
 		ctx.Data["EnableFeed"] = true
-		ctx.Data["FeedURL"] = ctx.Repo.Repository.HTMLURL()
+		ctx.Data["FeedURL"] = ctx.Repo.Repository.Link()
 	}
 
 	checkHomeCodeViewable(ctx)
diff --git a/routers/web/user/package.go b/routers/web/user/package.go
@@ -376,7 +376,7 @@ func PackageSettingsPost(ctx *context.Context) {
 			ctx.Flash.Success(ctx.Tr("packages.settings.delete.success"))
 		}
 
-		ctx.Redirect(ctx.Package.Owner.HTMLURL() + "/-/packages")
+		ctx.Redirect(ctx.Package.Owner.HomeLink() + "/-/packages")
 		return
 	}
 }
diff --git a/routers/web/user/profile.go b/routers/web/user/profile.go
@@ -47,7 +47,7 @@ func Profile(ctx *context.Context) {
 	}
 
 	// advertise feed via meta tag
-	ctx.Data["FeedURL"] = ctx.ContextUser.HTMLURL()
+	ctx.Data["FeedURL"] = ctx.ContextUser.HomeLink()
 
 	// Show OpenID URIs
 	openIDs, err := user_model.GetUserOpenIDs(ctx.ContextUser.ID)
diff --git a/services/actions/commit_status.go b/services/actions/commit_status.go
@@ -59,7 +59,7 @@ func CreateCommitStatus(ctx context.Context, job *actions_model.ActionRunJob) er
 		Creator: creator,
 		CommitStatus: &git_model.CommitStatus{
 			SHA:         sha,
-			TargetURL:   run.HTMLURL(),
+			TargetURL:   run.Link(),
 			Description: "",
 			Context:     ctxname,
 			CreatorID:   payload.Pusher.ID,

Original file line number	Diff line number	Diff line change
`@@ -274,7 +274,7 @@ func (repo *Repository) CommitLink(commitID string) (result string) {`
`274`	`274`	`if commitID == "" \|\| commitID == "0000000000000000000000000000000000000000" {`
`275`	`275`	`result = ""`
`276`	`276`	`} else {`
`277`		`- result = repo.HTMLURL() + "/commit/" + url.PathEscape(commitID)`
	`277`	`+ result = repo.Link() + "/commit/" + url.PathEscape(commitID)`
`278`	`278`	`}`
`279`	`279`	`return result`
`280`	`280`	`}`
Original file line number	Diff line number	Diff line change
`@@ -743,9 +743,9 @@ func RepoAssignment(ctx *Context) (cancel context.CancelFunc) {`
`743`	`743`
`744`	`744`	`if ctx.FormString("go-get") == "1" {`
`745`	`745`	`ctx.Data["GoGetImport"] = ComposeGoGetImport(owner.Name, repo.Name)`
`746`		`- prefix := repo.HTMLURL() + "/src/branch/" + util.PathEscapeSegments(ctx.Repo.BranchName)`
`747`		`- ctx.Data["GoDocDirectory"] = prefix + "{/dir}"`
`748`		`- ctx.Data["GoDocFile"] = prefix + "{/dir}/{file}#L{line}"`
	`746`	`+ fullURLPrefix := repo.HTMLURL() + "/src/branch/" + util.PathEscapeSegments(ctx.Repo.BranchName)`
	`747`	`+ ctx.Data["GoDocDirectory"] = fullURLPrefix + "{/dir}"`
	`748`	`+ ctx.Data["GoDocFile"] = fullURLPrefix + "{/dir}/{file}#L{line}"`
`749`	`749`	`}`
`750`	`750`	`return cancel`
`751`	`751`	`}`
Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func List(ctx *context.Context) {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`ctx.Data["workflows"] = workflows`
`73`		`- ctx.Data["RepoLink"] = ctx.Repo.Repository.HTMLURL()`
	`73`	`+ ctx.Data["RepoLink"] = ctx.Repo.Repository.Link()`
`74`	`74`
`75`	`75`	`page := ctx.FormInt("page")`
`76`	`76`	`if page <= 0 {`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ func MustAllowUserComment(ctx *context.Context) {`
`100`	`100`
`101`	`101`	`if issue.IsLocked && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) && !ctx.Doer.IsAdmin {`
`102`	`102`	`ctx.Flash.Error(ctx.Tr("repo.issues.comment_on_locked"))`
`103`		`- ctx.Redirect(issue.HTMLURL())`
	`103`	`+ ctx.Redirect(issue.Link())`
`104`	`104`	`return`
`105`	`105`	`}`
`106`	`106`	`}`
`@@ -927,7 +927,7 @@ func NewIssueChooseTemplate(ctx *context.Context) {`
`927`	`927`
`928`	`928`	`if len(issueTemplates) == 0 {`
`929`	`929`	`// The "issues/new" and "issues/new/choose" share the same query parameters "project" and "milestone", if no template here, just redirect to the "issues/new" page with these parameters.`
`930`		`- ctx.Redirect(fmt.Sprintf("%s/issues/new?%s", ctx.Repo.Repository.HTMLURL(), ctx.Req.URL.RawQuery), http.StatusSeeOther)`
	`930`	`+ ctx.Redirect(fmt.Sprintf("%s/issues/new?%s", ctx.Repo.Repository.Link(), ctx.Req.URL.RawQuery), http.StatusSeeOther)`
`931`	`931`	`return`
`932`	`932`	`}`
`933`	`933`
`@@ -950,11 +950,11 @@ func DeleteIssue(ctx *context.Context) {`
`950`	`950`	`}`
`951`	`951`
`952`	`952`	`if issue.IsPull {`
`953`		`- ctx.Redirect(fmt.Sprintf("%s/pulls", ctx.Repo.Repository.HTMLURL()), http.StatusSeeOther)`
	`953`	`+ ctx.Redirect(fmt.Sprintf("%s/pulls", ctx.Repo.Repository.Link()), http.StatusSeeOther)`
`954`	`954`	`return`
`955`	`955`	`}`
`956`	`956`
`957`		`- ctx.Redirect(fmt.Sprintf("%s/issues", ctx.Repo.Repository.HTMLURL()), http.StatusSeeOther)`
	`957`	`+ ctx.Redirect(fmt.Sprintf("%s/issues", ctx.Repo.Repository.Link()), http.StatusSeeOther)`
`958`	`958`	`}`
`959`	`959`
`960`	`960`	`// ValidateRepoMetas check and returns repository's meta information`
`@@ -1425,7 +1425,7 @@ func ViewIssue(ctx *context.Context) {`
`1425`	`1425`	`return`
`1426`	`1426`	`}`
`1427`	`1427`	`// Add link to the issue of the already running stopwatch`
`1428`		`- ctx.Data["OtherStopwatchURL"] = otherIssue.HTMLURL()`
	`1428`	`+ ctx.Data["OtherStopwatchURL"] = otherIssue.Link()`
`1429`	`1429`	`}`
`1430`	`1430`	`}`
`1431`	`1431`	`ctx.Data["CanUseTimetracker"] = ctx.Repo.CanUseTimetracker(issue, ctx.Doer)`
`@@ -2658,7 +2658,7 @@ func NewComment(ctx *context.Context) {`
`2658`	`2658`
`2659`	`2659`	`if issue.IsLocked && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull) && !ctx.Doer.IsAdmin {`
`2660`	`2660`	`ctx.Flash.Error(ctx.Tr("repo.issues.comment_on_locked"))`
`2661`		`- ctx.Redirect(issue.HTMLURL())`
	`2661`	`+ ctx.Redirect(issue.Link())`
`2662`	`2662`	`return`
`2663`	`2663`	`}`
`2664`	`2664`
`@@ -2669,7 +2669,7 @@ func NewComment(ctx *context.Context) {`
`2669`	`2669`
`2670`	`2670`	`if ctx.HasError() {`
`2671`	`2671`	`ctx.Flash.Error(ctx.Data["ErrorMsg"].(string))`
`2672`		`- ctx.Redirect(issue.HTMLURL())`
	`2672`	`+ ctx.Redirect(issue.Link())`
`2673`	`2673`	`return`
`2674`	`2674`	`}`
`2675`	`2675`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ func AddDependency(ctx *context.Context) {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`// Redirect`
`37`		`- defer ctx.Redirect(issue.HTMLURL())`
	`37`	`+ defer ctx.Redirect(issue.Link())`
`38`	`38`
`39`	`39`	`// Dependency`
`40`	`40`	`dep, err := issues_model.GetIssueByID(ctx, depID)`
`@@ -124,5 +124,5 @@ func RemoveDependency(ctx *context.Context) {`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`// Redirect`
`127`		`- ctx.Redirect(issue.HTMLURL())`
	`127`	`+ ctx.Redirect(issue.Link())`
`128`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,13 +21,13 @@ func LockIssue(ctx *context.Context) {`
`21`	`21`
`22`	`22`	`if issue.IsLocked {`
`23`	`23`	`ctx.Flash.Error(ctx.Tr("repo.issues.lock_duplicate"))`
`24`		`- ctx.Redirect(issue.HTMLURL())`
	`24`	`+ ctx.Redirect(issue.Link())`
`25`	`25`	`return`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`if !form.HasValidReason() {`
`29`	`29`	`ctx.Flash.Error(ctx.Tr("repo.issues.lock.unknown_reason"))`
`30`		`- ctx.Redirect(issue.HTMLURL())`
	`30`	`+ ctx.Redirect(issue.Link())`
`31`	`31`	`return`
`32`	`32`	`}`
`33`	`33`
`@@ -40,7 +40,7 @@ func LockIssue(ctx *context.Context) {`
`40`	`40`	`return`
`41`	`41`	`}`
`42`	`42`
`43`		`- ctx.Redirect(issue.HTMLURL())`
	`43`	`+ ctx.Redirect(issue.Link())`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`// UnlockIssue unlocks a previously locked issue.`
`@@ -52,7 +52,7 @@ func UnlockIssue(ctx *context.Context) {`
`52`	`52`
`53`	`53`	`if !issue.IsLocked {`
`54`	`54`	`ctx.Flash.Error(ctx.Tr("repo.issues.unlock_error"))`
`55`		`- ctx.Redirect(issue.HTMLURL())`
	`55`	`+ ctx.Redirect(issue.Link())`
`56`	`56`	`return`
`57`	`57`	`}`
`58`	`58`
`@@ -64,5 +64,5 @@ func UnlockIssue(ctx *context.Context) {`
`64`	`64`	`return`
`65`	`65`	`}`
`66`	`66`
`67`		`- ctx.Redirect(issue.HTMLURL())`
	`67`	`+ ctx.Redirect(issue.Link())`
`68`	`68`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func IssueStopwatch(c *context.Context) {`
`40`	`40`	`c.Flash.Success(c.Tr("repo.issues.tracker_auto_close"))`
`41`	`41`	`}`
`42`	`42`
`43`		`- url := issue.HTMLURL()`
	`43`	`+ url := issue.Link()`
`44`	`44`	`c.Redirect(url, http.StatusSeeOther)`
`45`	`45`	`}`
`46`	`46`
`@@ -72,7 +72,7 @@ func CancelStopwatch(c *context.Context) {`
`72`	`72`	`})`
`73`	`73`	`}`
`74`	`74`
`75`		`- url := issue.HTMLURL()`
	`75`	`+ url := issue.Link()`
`76`	`76`	`c.Redirect(url, http.StatusSeeOther)`
`77`	`77`	`}`
`78`	`78`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ func AddTimeManually(c *context.Context) {`
`26`	`26`	`c.NotFound("CanUseTimetracker", nil)`
`27`	`27`	`return`
`28`	`28`	`}`
`29`		`- url := issue.HTMLURL()`
	`29`	`+ url := issue.Link()`
`30`	`30`
`31`	`31`	`if c.HasError() {`
`32`	`32`	`c.Flash.Error(c.GetErrMsg())`
`@@ -83,5 +83,5 @@ func DeleteTime(c *context.Context) {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`c.Flash.Success(c.Tr("repo.issues.del_time_history", util.SecToTime(t.Time)))`
`86`		`- c.Redirect(issue.HTMLURL())`
	`86`	`+ c.Redirect(issue.Link())`
`87`	`87`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,5 +52,5 @@ func IssueWatch(ctx *context.Context) {`
`52`	`52`	`return`
`53`	`53`	`}`
`54`	`54`
`55`		`- ctx.Redirect(issue.HTMLURL())`
	`55`	`+ ctx.Redirect(issue.Link())`
`56`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,7 @@ func CreateCodeComment(ctx *context.Context) {`
`98`	`98`	`renderConversation(ctx, comment)`
`99`	`99`	`return`
`100`	`100`	`}`
`101`		`- ctx.Redirect(comment.HTMLURL())`
	`101`	`+ ctx.Redirect(comment.Link())`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`// UpdateResolveConversation add or remove an Conversation resolved mark`