Skip to content

Commit e65cfab

Browse files
authored
Remove spurious DataAsync Error logging (#14599)
Breaking the pipe is a valid way of killing a piped command and any error from a broken cat-file batch command should be passed back up to the writer any way therefore specifically logging it is unnecessary. Signed-off-by: Andrew Thornton <[email protected]>
1 parent 5f248d0 commit e65cfab

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

modules/git/blob_nogogit.go

-3
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ import (
1111
"io"
1212
"strconv"
1313
"strings"
14-
15-
gitea_log "code.gitea.io/gitea/modules/log"
1614
)
1715

1816
// Blob represents a Git object.
@@ -35,7 +33,6 @@ func (b *Blob) DataAsync() (io.ReadCloser, error) {
3533
err := NewCommand("cat-file", "--batch").RunInDirFullPipeline(b.repoPath, stdoutWriter, stderr, strings.NewReader(b.ID.String()+"\n"))
3634
if err != nil {
3735
err = ConcatenateError(err, stderr.String())
38-
gitea_log.Error("Blob.DataAsync Error: %v", err)
3936
_ = stdoutWriter.CloseWithError(err)
4037
} else {
4138
_ = stdoutWriter.Close()

0 commit comments

Comments
 (0)