Change to use the :(literal) magic instead of escaping

kbolashev · kbolashev · commit e5edcc1177ff · 2023-02-18T20:51:35.000+02:00
diff --git a/modules/git/log_name_status.go b/modules/git/log_name_status.go
@@ -56,11 +56,9 @@ func LogNameStatusRepo(ctx context.Context, repository, head, treepath string, p
 	} else if treepath != "" {
 		files = append(files, treepath)
 	}
-	// Escape colons at the start of filenames, because `git log -- :filename` returns nothing
+	// Use the :(literal) pathspec magic to handle edge cases with files named like ":file.txt" or "*.jpg"
 	for i, file := range files {
-		if strings.HasPrefix(file, ":") {
-			files[i] = "\\" + file
-		}
+		files[i] = ":(literal)" + file
 	}
 	cmd.AddDashesAndList(files...)
 

Original file line number	Diff line number	Diff line change
`@@ -56,11 +56,9 @@ func LogNameStatusRepo(ctx context.Context, repository, head, treepath string, p`
`56`	`56`	`} else if treepath != "" {`
`57`	`57`	`files = append(files, treepath)`
`58`	`58`	`}`
`59`		- // Escape colons at the start of filenames, because `git log -- :filename` returns nothing
	`59`	`+ // Use the :(literal) pathspec magic to handle edge cases with files named like ":file.txt" or "*.jpg"`
`60`	`60`	`for i, file := range files {`
`61`		`- if strings.HasPrefix(file, ":") {`
`62`		`- files[i] = "\\" + file`
`63`		`- }`
	`61`	`+ files[i] = ":(literal)" + file`
`64`	`62`	`}`
`65`	`63`	`cmd.AddDashesAndList(files...)`
`66`	`64`