Skip to content

Commit e46a8c9

Browse files
fnetX6543Gustedlunny
authored
Fix potential assignee query for repo (#18994)
* Fix potential assignee query for repo * Add tests for `GetRepoAssignees` - As per #18994 (comment) Co-authored-by: 6543 <[email protected]> Co-authored-by: Gusted <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
1 parent 5184c83 commit e46a8c9

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

models/repo.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func getRepoAssignees(ctx context.Context, repo *repo_model.Repository) (_ []*us
153153
userIDs := make([]int64, 0, 10)
154154
if err = e.Table("access").
155155
Where("repo_id = ? AND mode >= ?", repo.ID, perm.AccessModeWrite).
156-
Select("id").
156+
Select("user_id").
157157
Find(&userIDs); err != nil {
158158
return nil, err
159159
}

models/repo_test.go

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,3 +167,21 @@ func TestLinkedRepository(t *testing.T) {
167167
})
168168
}
169169
}
170+
171+
func TestRepoAssignees(t *testing.T) {
172+
assert.NoError(t, unittest.PrepareTestDatabase())
173+
174+
repo2 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2}).(*repo_model.Repository)
175+
users, err := GetRepoAssignees(repo2)
176+
assert.NoError(t, err)
177+
assert.Len(t, users, 1)
178+
assert.Equal(t, users[0].ID, int64(2))
179+
180+
repo21 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 21}).(*repo_model.Repository)
181+
users, err = GetRepoAssignees(repo21)
182+
assert.NoError(t, err)
183+
assert.Len(t, users, 3)
184+
assert.Equal(t, users[0].ID, int64(15))
185+
assert.Equal(t, users[1].ID, int64(18))
186+
assert.Equal(t, users[2].ID, int64(16))
187+
}

0 commit comments

Comments
 (0)