Skip to content

Commit e06f3d2

Browse files
authored
Enable vue/html-closing-bracket-spacing eslint rule (#24987)
Enable [`vue/html-closing-bracket-spacing`](https://eslint.vuejs.org/rules/html-closing-bracket-spacing.html) and set it to never add any useless spaces inside tags. All issues were fixed automatically with `make lint-js-fix`.
1 parent 085a885 commit e06f3d2

7 files changed

+7
-7
lines changed

web_src/js/components/.eslintrc.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ env:
1010

1111
rules:
1212
vue/attributes-order: [0]
13-
vue/html-closing-bracket-spacing: [0]
13+
vue/html-closing-bracket-spacing: [2, {startTag: never, endTag: never, selfClosingTag: never}]
1414
vue/max-attributes-per-line: [0]

web_src/js/components/ActionRunStatus.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<SvgIcon name="octicon-clock" class="text yellow" :size="size" :class-name="className" v-else-if="status === 'waiting'"/>
1010
<SvgIcon name="octicon-blocked" class="text yellow" :size="size" :class-name="className" v-else-if="status === 'blocked'"/>
1111
<SvgIcon name="octicon-meter" class="text yellow" :size="size" :class-name="'job-status-rotate ' + className" v-else-if="status === 'running'"/>
12-
<SvgIcon name="octicon-x-circle-fill" class="text red" :size="size" v-else-if="['failure', 'cancelled', 'unknown'].includes(status)" />
12+
<SvgIcon name="octicon-x-circle-fill" class="text red" :size="size" v-else-if="['failure', 'cancelled', 'unknown'].includes(status)"/>
1313
</span>
1414
</template>
1515

web_src/js/components/ContextPopup.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div v-if="loading" class="ui active centered inline loader"/>
44
<div v-if="!loading && issue !== null">
55
<p><small>{{ issue.repository.full_name }} on {{ createdAt }}</small></p>
6-
<p><svg-icon :name="icon" :class="['text', color]" /> <strong>{{ issue.title }}</strong> #{{ issue.number }}</p>
6+
<p><svg-icon :name="icon" :class="['text', color]"/> <strong>{{ issue.title }}</strong> #{{ issue.number }}</p>
77
<p>{{ body }}</p>
88
<div>
99
<div

web_src/js/components/DiffFileList.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<span v-if="file.IsBin" class="gt-ml-1 gt-mr-3">{{ binaryFileMessage }}</span>
66
{{ file.IsBin ? '' : file.Addition + file.Deletion }}
77
<span v-if="!file.IsBin" class="diff-stats-bar gt-mx-3" :data-tooltip-content="statisticsMessage.replace('%d', (file.Addition + file.Deletion)).replace('%d', file.Addition).replace('%d', file.Deletion)">
8-
<div class="diff-stats-add-bar" :style="{ 'width': diffStatsWidth(file.Addition, file.Deletion) }" />
8+
<div class="diff-stats-add-bar" :style="{ 'width': diffStatsWidth(file.Addition, file.Deletion) }"/>
99
</span>
1010
</div>
1111
<!-- todo finish all file status, now modify, add, delete and rename -->

web_src/js/components/PullRequestMergeForm.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262

6363
<div v-if="!showActionForm" class="gt-df">
6464
<!-- the merge button -->
65-
<div class="ui buttons merge-button" :class="[mergeForm.emptyCommit ? 'grey' : mergeForm.allOverridableChecksOk ? 'green' : 'red']" @click="toggleActionForm(true)" >
65+
<div class="ui buttons merge-button" :class="[mergeForm.emptyCommit ? 'grey' : mergeForm.allOverridableChecksOk ? 'green' : 'red']" @click="toggleActionForm(true)">
6666
<button class="ui button">
6767
<svg-icon name="octicon-git-merge"/>
6868
<span class="button-text">

web_src/js/components/RepoActionView.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
<ul class="job-artifacts-list">
5252
<li class="job-artifacts-item" v-for="artifact in artifacts" :key="artifact.id">
5353
<a class="job-artifacts-link" target="_blank" :href="run.link+'/artifacts/'+artifact.id">
54-
<SvgIcon name="octicon-file" class="ui text black job-artifacts-icon" />{{ artifact.name }}
54+
<SvgIcon name="octicon-file" class="ui text black job-artifacts-icon"/>{{ artifact.name }}
5555
</a>
5656
</li>
5757
</ul>

web_src/js/components/RepoBranchTagSelector.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<span class="text gt-df gt-ac gt-mr-2">
55
<template v-if="release">{{ textReleaseCompare }}</template>
66
<template v-else>
7-
<svg-icon v-if="isViewTag" name="octicon-tag" />
7+
<svg-icon v-if="isViewTag" name="octicon-tag"/>
88
<svg-icon v-else name="octicon-git-branch"/>
99
<strong ref="dropdownRefName" class="gt-ml-3">{{ refNameText }}</strong>
1010
</template>

0 commit comments

Comments
 (0)