Skip to content

Commit db0c498

Browse files
committed
fix tests
1 parent 57517b6 commit db0c498

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

models/issue_milestone.go

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -312,18 +312,31 @@ func ChangeMilestoneStatus(m *Milestone, isClosed bool) (err error) {
312312
}
313313

314314
func updateMilestoneTotalNum(e Engine, milestoneID int64) (err error) {
315-
_, err = e.Exec("UPDATE `milestone` SET num_issues=(SELECT count(*) FROM issue WHERE milestone_id=?), completeness=if(num_issues>0,100*num_closed_issues/num_issues, 0) WHERE id=?",
315+
if _, err = e.Exec("UPDATE `milestone` SET num_issues=(SELECT count(*) FROM issue WHERE milestone_id=?) WHERE id=?",
316316
milestoneID,
317317
milestoneID,
318+
); err != nil {
319+
return
320+
}
321+
322+
_, err = e.Exec("UPDATE `milestone` SET completeness=if(num_issues>0,100*num_closed_issues/num_issues, 0) WHERE id=?",
323+
milestoneID,
318324
)
325+
319326
return
320327
}
321328

322329
func updateMilestoneClosedNum(e Engine, milestoneID int64) (err error) {
323-
_, err = e.Exec("UPDATE `milestone` SET num_closed_issues=(SELECT count(*) FROM issue WHERE milestone_id=? AND is_closed=?), completeness=if(num_issues>0,100*num_closed_issues/num_issues, 0) WHERE id=?",
330+
if _, err = e.Exec("UPDATE `milestone` SET num_closed_issues=(SELECT count(*) FROM issue WHERE milestone_id=? AND is_closed=?) WHERE id=?",
324331
milestoneID,
325332
true,
326333
milestoneID,
334+
); err != nil {
335+
return
336+
}
337+
338+
_, err = e.Exec("UPDATE `milestone` SET completeness=if(num_issues>0,100*num_closed_issues/num_issues, 0) WHERE id=?",
339+
milestoneID,
327340
)
328341
return
329342
}

0 commit comments

Comments
 (0)