Fix wrong workflow status when rerun a job in an already finished workflow (#26119)

yp05327 · web-flow · commit d817b199cab8 · 2023-07-25T09:13:36.000Z
Before: ![image](https://github.com/go-gitea/gitea/assets/18380374/fb687592-b117-4cd5-b076-2ca5ca847ea4) After: ![image](https://github.com/go-gitea/gitea/assets/18380374/c9b0683e-e81d-410b-8c35-fbe54327fab4) After workflow finished, if you rerun a single job, the workflow status will become to `Running` which is not correct as no jobs are running in this workflow.
diff --git a/models/actions/run_job.go b/models/actions/run_job.go
@@ -150,7 +150,7 @@ func aggregateJobStatus(jobs []*ActionRunJob) Status {
 		if !job.Status.IsDone() {
 			allDone = false
 		}
-		if job.Status != StatusWaiting {
+		if job.Status != StatusWaiting && !job.Status.IsDone() {
 			allWaiting = false
 		}
 		if job.Status == StatusFailure || job.Status == StatusCancelled {

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ func aggregateJobStatus(jobs []*ActionRunJob) Status {`
`150`	`150`	`if !job.Status.IsDone() {`
`151`	`151`	`allDone = false`
`152`	`152`	`}`
`153`		`- if job.Status != StatusWaiting {`
	`153`	`+ if job.Status != StatusWaiting && !job.Status.IsDone() {`
`154`	`154`	`allWaiting = false`
`155`	`155`	`}`
`156`	`156`	`if job.Status == StatusFailure \|\| job.Status == StatusCancelled {`