Skip to content

Commit cd8cdbd

Browse files
stevegtlunny
authored andcommitted
fix testing instructions in CONTRIBUTING.md (#6305)
* add scripts/test-local.sh and fix CONTRIBUTING.md - fixes #6243 - partial fix for #6269 Signed-off-by: Steve Traugott <[email protected]> * remove reference to possible automated drone run * remove bash version of drone-cli test script * fix issue number links in testing instructions * remove scripts/test-local.sh
1 parent 1155f1b commit cd8cdbd

File tree

1 file changed

+20
-9
lines changed

1 file changed

+20
-9
lines changed

CONTRIBUTING.md

+20-9
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,26 @@ high-level discussions.
6464

6565
## Testing redux
6666

67-
Before sending code out for review, run all the tests for the
68-
whole tree to make sure the changes don't break other usage
69-
and keep the compatibility on upgrade. To make sure you are
70-
running the test suite exactly like we do, you should install
71-
the CLI for [Drone CI](https://github.com/drone/drone), as
72-
we are using the server for continuous testing, following [these
73-
instructions](http://docs.drone.io/cli-installation/). After that,
74-
you can simply call `drone exec --local --build-event "pull_request"` within
75-
your working directory and it will try to run the test suite locally.
67+
Before submitting a pull request, run all the tests for the whole tree
68+
to make sure your changes don't cause regression elsewhere.
69+
70+
Here's how to run the test suite:
71+
72+
- Install the correct version of the drone-cli package. As of this
73+
writing, the correct drone-cli version is
74+
[0.8.6](https://0-8-0.docs.drone.io/cli-installation/).
75+
- Ensure you have enough free disk space. You will need at least
76+
15-20 Gb of free disk space to hold all of the containers drone
77+
creates (a default AWS or GCE disk size won't work -- see
78+
[#6243](https://github.com/go-gitea/gitea/issues/6243)).
79+
- Change into the base directory of your copy of the gitea repository,
80+
and run `drone exec --local --build-event pull_request`.
81+
82+
The drone version, command line, and disk requirements do change over
83+
time (see [#4053](https://github.com/go-gitea/gitea/issues/4053) and
84+
[#6243](https://github.com/go-gitea/gitea/issues/6243)); if you
85+
discover any issues, please feel free to send us a pull request to
86+
update these instructions.
7687

7788
## Vendoring
7889

0 commit comments

Comments
 (0)