fix adding reaction fail for read permission (#5515)

lunny · techknowlogick · commit ccea91652f8d · 2018-12-11T13:12:06.000-05:00
diff --git a/routers/repo/issue.go b/routers/repo/issue.go
@@ -1248,7 +1248,7 @@ func ChangeIssueReaction(ctx *context.Context, form auth.ReactionForm) {
 		return
 	}
 
-	if !ctx.IsSigned || (ctx.User.ID != issue.PosterID && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)) {
+	if !ctx.IsSigned || (ctx.User.ID != issue.PosterID && !ctx.Repo.CanReadIssuesOrPulls(issue.IsPull)) {
 		ctx.Error(403)
 		return
 	}
@@ -1327,7 +1327,7 @@ func ChangeCommentReaction(ctx *context.Context, form auth.ReactionForm) {
 		return
 	}
 
-	if !ctx.IsSigned || (ctx.User.ID != comment.PosterID && !ctx.Repo.CanWriteIssuesOrPulls(comment.Issue.IsPull)) {
+	if !ctx.IsSigned || (ctx.User.ID != comment.PosterID && !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull)) {
 		ctx.Error(403)
 		return
 	} else if comment.Type != models.CommentTypeComment && comment.Type != models.CommentTypeCode {

Original file line number	Diff line number	Diff line change
`@@ -1248,7 +1248,7 @@ func ChangeIssueReaction(ctx *context.Context, form auth.ReactionForm) {`
`1248`	`1248`	`return`
`1249`	`1249`	`}`
`1250`	`1250`
`1251`		`- if !ctx.IsSigned \|\| (ctx.User.ID != issue.PosterID && !ctx.Repo.CanWriteIssuesOrPulls(issue.IsPull)) {`
	`1251`	`+ if !ctx.IsSigned \|\| (ctx.User.ID != issue.PosterID && !ctx.Repo.CanReadIssuesOrPulls(issue.IsPull)) {`
`1252`	`1252`	`ctx.Error(403)`
`1253`	`1253`	`return`
`1254`	`1254`	`}`
`@@ -1327,7 +1327,7 @@ func ChangeCommentReaction(ctx *context.Context, form auth.ReactionForm) {`
`1327`	`1327`	`return`
`1328`	`1328`	`}`
`1329`	`1329`
`1330`		`- if !ctx.IsSigned \|\| (ctx.User.ID != comment.PosterID && !ctx.Repo.CanWriteIssuesOrPulls(comment.Issue.IsPull)) {`
	`1330`	`+ if !ctx.IsSigned \|\| (ctx.User.ID != comment.PosterID && !ctx.Repo.CanReadIssuesOrPulls(comment.Issue.IsPull)) {`
`1331`	`1331`	`ctx.Error(403)`
`1332`	`1332`	`return`
`1333`	`1333`	`} else if comment.Type != models.CommentTypeComment && comment.Type != models.CommentTypeCode {`