Skip to content

Commit c87dd55

Browse files
committed
#13190 Notification when WIP Pull Request is ready for review
1 parent bab067b commit c87dd55

File tree

2 files changed

+25
-0
lines changed

2 files changed

+25
-0
lines changed

modules/notification/mail/mail.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,18 @@ func (m *mailNotifier) NotifyIssueChangeStatus(doer *models.User, issue *models.
7474
}
7575
}
7676

77+
func (m *mailNotifier) NotifyIssueChangeTitle(doer *models.User, issue *models.Issue, oldTitle string) {
78+
if err := issue.LoadPullRequest(); err != nil {
79+
log.Error("issue.LoadPullRequest: %v", err)
80+
return
81+
}
82+
if issue.IsPull && models.HasWorkInProgressPrefix(oldTitle) && !issue.PullRequest.IsWorkInProgress() {
83+
if err := mailer.MailParticipants(issue, doer, models.ActionCreatePullRequest, nil); err != nil {
84+
log.Error("MailParticipants: %v", err)
85+
}
86+
}
87+
}
88+
7789
func (m *mailNotifier) NotifyNewPullRequest(pr *models.PullRequest, mentions []*models.User) {
7890
if err := mailer.MailParticipants(pr.Issue, pr.Issue.Poster, models.ActionCreatePullRequest, mentions); err != nil {
7991
log.Error("MailParticipants: %v", err)

modules/notification/ui/ui.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,19 @@ func (ns *notificationService) NotifyIssueChangeStatus(doer *models.User, issue
9494
})
9595
}
9696

97+
func (ns *notificationService) NotifyIssueChangeTitle(doer *models.User, issue *models.Issue, oldTitle string) {
98+
if err := issue.LoadPullRequest(); err != nil {
99+
log.Error("issue.LoadPullRequest: %v", err)
100+
return
101+
}
102+
if issue.IsPull && models.HasWorkInProgressPrefix(oldTitle) && !issue.PullRequest.IsWorkInProgress() {
103+
_ = ns.issueQueue.Push(issueNotificationOpts{
104+
IssueID: issue.ID,
105+
NotificationAuthorID: doer.ID,
106+
})
107+
}
108+
}
109+
97110
func (ns *notificationService) NotifyMergePullRequest(pr *models.PullRequest, doer *models.User) {
98111
_ = ns.issueQueue.Push(issueNotificationOpts{
99112
IssueID: pr.Issue.ID,

0 commit comments

Comments
 (0)