Revert "Make buttons in a modal form have proper type. (#25446)" (#25485)

wxiaoguang · web-flow · commit b8253607fea3 · 2023-06-25T10:03:09.000+08:00
There is a side effect because some modal doesn't have a proper "ok" button. This reverts commit a954c93.
diff --git a/web_src/js/features/common-global.js b/web_src/js/features/common-global.js
@@ -395,8 +395,6 @@ function initGlobalShowModal() {
     if (colorPickers.length > 0) {
       initCompColorPicker(); // FIXME: this might cause duplicate init
     }
-    // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter"
-    $modal.find('form button:not(.ok):not([type])').attr('type', 'button');
     $modal.modal('setting', {
       onApprove: () => {
         // "form-fetch-action" can handle network errors gracefully,

Original file line number	Diff line number	Diff line change
`@@ -395,8 +395,6 @@ function initGlobalShowModal() {`
`395`	`395`	`if (colorPickers.length > 0) {`
`396`	`396`	`initCompColorPicker(); // FIXME: this might cause duplicate init`
`397`	`397`	`}`
`398`		`- // all non-"ok" buttons which do not have "type" should not submit the form, should not be triggered by "Enter"`
`399`		`- $modal.find('form button:not(.ok):not([type])').attr('type', 'button');`
`400`	`398`	`$modal.modal('setting', {`
`401`	`399`	`onApprove: () => {`
`402`	`400`	`// "form-fetch-action" can handle network errors gracefully,`