Skip to content

Commit b1dd1ba

Browse files
silverwindlunny6543
authored
Update JS dependencies and misc tweaks (#21583)
- Update all JS dependencies to latest version - Disable two redundant eslint rules - Adapt stylelint config to codebase - Regenerate SVGs - Make file editor spinner "reserve" height so page does not shift - Tested katex, swagger, monaco Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: 6543 <[email protected]>
1 parent f337c32 commit b1dd1ba

19 files changed

+867
-827
lines changed

.drone.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ steps:
561561

562562
# TODO: We should probably build all dependencies into a test image
563563
- name: test-e2e
564-
image: mcr.microsoft.com/playwright:v1.27.0-focal
564+
image: mcr.microsoft.com/playwright:v1.27.1-focal
565565
commands:
566566
- curl -sLO https://go.dev/dl/go1.19.linux-amd64.tar.gz && tar -C /usr/local -xzf go1.19.linux-amd64.tar.gz
567567
- groupadd --gid 1001 gitea && useradd -m --gid 1001 --uid 1001 gitea

.eslintrc.yaml

+6-6
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,7 @@ rules:
254254
no-irregular-whitespace: [2]
255255
no-iterator: [2]
256256
no-label-var: [2]
257-
no-labels: [2]
257+
no-labels: [0]
258258
no-lone-blocks: [2]
259259
no-lonely-if: [0]
260260
no-loop-func: [0]
@@ -333,7 +333,7 @@ rules:
333333
no-void: [2]
334334
no-warning-comments: [0]
335335
no-whitespace-before-property: [2]
336-
no-with: [2]
336+
no-with: [0]
337337
nonblock-statement-body-position: [2]
338338
object-curly-newline: [0]
339339
object-curly-spacing: [2, never]
@@ -378,11 +378,11 @@ rules:
378378
sonarjs/no-duplicated-branches: [0]
379379
sonarjs/no-element-overwrite: [2]
380380
sonarjs/no-empty-collection: [2]
381-
sonarjs/no-extra-arguments: [0]
381+
sonarjs/no-extra-arguments: [2]
382382
sonarjs/no-gratuitous-expressions: [2]
383383
sonarjs/no-identical-conditions: [2]
384-
sonarjs/no-identical-expressions: [0]
385-
sonarjs/no-identical-functions: [0]
384+
sonarjs/no-identical-expressions: [2]
385+
sonarjs/no-identical-functions: [2, 5]
386386
sonarjs/no-ignored-return: [2]
387387
sonarjs/no-inverted-boolean-check: [2]
388388
sonarjs/no-nested-switch: [0]
@@ -394,7 +394,7 @@ rules:
394394
sonarjs/no-small-switch: [0]
395395
sonarjs/no-unused-collection: [2]
396396
sonarjs/no-use-of-empty-return-value: [2]
397-
sonarjs/no-useless-catch: [0]
397+
sonarjs/no-useless-catch: [2]
398398
sonarjs/non-existent-operator: [2]
399399
sonarjs/prefer-immediate-return: [0]
400400
sonarjs/prefer-object-literal: [0]

.stylelintrc.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ rules:
1616
declaration-empty-line-before: null
1717
function-no-unknown: null
1818
hue-degree-notation: null
19+
import-notation: string
1920
indentation: 2
2021
max-line-length: null
2122
no-descending-specificity: null

0 commit comments

Comments
 (0)