Skip to content

Commit ac6c338

Browse files
authored
Add API to check if team has repo access (#19540)
* Add API to check if team has repo access * Add test case
1 parent edff571 commit ac6c338

File tree

4 files changed

+117
-1
lines changed

4 files changed

+117
-1
lines changed

integrations/api_team_test.go

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"testing"
1212

1313
"code.gitea.io/gitea/models/organization"
14+
"code.gitea.io/gitea/models/repo"
1415
"code.gitea.io/gitea/models/unit"
1516
"code.gitea.io/gitea/models/unittest"
1617
user_model "code.gitea.io/gitea/models/user"
@@ -239,3 +240,26 @@ func TestAPITeamSearch(t *testing.T) {
239240
req = NewRequestf(t, "GET", "/api/v1/orgs/%s/teams/search?q=%s&token=%s", org.Name, "team", token5)
240241
MakeRequest(t, req, http.StatusForbidden)
241242
}
243+
244+
func TestAPIGetTeamRepo(t *testing.T) {
245+
defer prepareTestEnv(t)()
246+
247+
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 15}).(*user_model.User)
248+
teamRepo := unittest.AssertExistsAndLoadBean(t, &repo.Repository{ID: 24}).(*repo.Repository)
249+
team := unittest.AssertExistsAndLoadBean(t, &organization.Team{ID: 5}).(*organization.Team)
250+
251+
var results api.Repository
252+
253+
token := getUserToken(t, user.Name)
254+
req := NewRequestf(t, "GET", "/api/v1/teams/%d/repos/%s/?token=%s", team.ID, teamRepo.FullName(), token)
255+
resp := MakeRequest(t, req, http.StatusOK)
256+
DecodeJSON(t, resp, &results)
257+
assert.Equal(t, "big_test_private_4", teamRepo.Name)
258+
259+
// no access if not organization member
260+
user5 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 5}).(*user_model.User)
261+
token5 := getUserToken(t, user5.Name)
262+
263+
req = NewRequestf(t, "GET", "/api/v1/teams/%d/repos/%s/?token=%s", team.ID, teamRepo.FullName(), token5)
264+
MakeRequest(t, req, http.StatusNotFound)
265+
}

routers/api/v1/api.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1121,7 +1121,8 @@ func Routes() *web.Route {
11211121
m.Get("", org.GetTeamRepos)
11221122
m.Combo("/{org}/{reponame}").
11231123
Put(org.AddTeamRepository).
1124-
Delete(org.RemoveTeamRepository)
1124+
Delete(org.RemoveTeamRepository).
1125+
Get(org.GetTeamRepo)
11251126
})
11261127
}, orgAssignment(false, true), reqToken(), reqTeamMembership())
11271128

routers/api/v1/org/team.go

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -558,6 +558,55 @@ func GetTeamRepos(ctx *context.APIContext) {
558558
ctx.JSON(http.StatusOK, repos)
559559
}
560560

561+
// GetTeamRepo api for get a particular repo of team
562+
func GetTeamRepo(ctx *context.APIContext) {
563+
// swagger:operation GET /teams/{id}/repos/{org}/{repo} organization orgListTeamRepo
564+
// ---
565+
// summary: List a particular repo of team
566+
// produces:
567+
// - application/json
568+
// parameters:
569+
// - name: id
570+
// in: path
571+
// description: id of the team
572+
// type: integer
573+
// format: int64
574+
// required: true
575+
// - name: org
576+
// in: path
577+
// description: organization that owns the repo to list
578+
// type: string
579+
// required: true
580+
// - name: repo
581+
// in: path
582+
// description: name of the repo to list
583+
// type: string
584+
// required: true
585+
// responses:
586+
// "200":
587+
// "$ref": "#/responses/Repository"
588+
// "404":
589+
// "$ref": "#/responses/notFound"
590+
591+
repo := getRepositoryByParams(ctx)
592+
if ctx.Written() {
593+
return
594+
}
595+
596+
if !organization.HasTeamRepo(ctx, ctx.Org.Team.OrgID, ctx.Org.Team.ID, repo.ID) {
597+
ctx.NotFound()
598+
return
599+
}
600+
601+
access, err := models.AccessLevel(ctx.Doer, repo)
602+
if err != nil {
603+
ctx.Error(http.StatusInternalServerError, "GetTeamRepos", err)
604+
return
605+
}
606+
607+
ctx.JSON(http.StatusOK, convert.ToRepo(repo, access))
608+
}
609+
561610
// getRepositoryByParams get repository by a team's organization ID and repo name
562611
func getRepositoryByParams(ctx *context.APIContext) *repo_model.Repository {
563612
repo, err := repo_model.GetRepositoryByName(ctx.Org.Team.OrgID, ctx.Params(":reponame"))

templates/swagger/v1_json.tmpl

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11114,6 +11114,48 @@
1111411114
}
1111511115
},
1111611116
"/teams/{id}/repos/{org}/{repo}": {
11117+
"get": {
11118+
"produces": [
11119+
"application/json"
11120+
],
11121+
"tags": [
11122+
"organization"
11123+
],
11124+
"summary": "List a particular repo of team",
11125+
"operationId": "orgListTeamRepo",
11126+
"parameters": [
11127+
{
11128+
"type": "integer",
11129+
"format": "int64",
11130+
"description": "id of the team",
11131+
"name": "id",
11132+
"in": "path",
11133+
"required": true
11134+
},
11135+
{
11136+
"type": "string",
11137+
"description": "organization that owns the repo to list",
11138+
"name": "org",
11139+
"in": "path",
11140+
"required": true
11141+
},
11142+
{
11143+
"type": "string",
11144+
"description": "name of the repo to list",
11145+
"name": "repo",
11146+
"in": "path",
11147+
"required": true
11148+
}
11149+
],
11150+
"responses": {
11151+
"200": {
11152+
"$ref": "#/responses/Repository"
11153+
},
11154+
"404": {
11155+
"$ref": "#/responses/notFound"
11156+
}
11157+
}
11158+
},
1111711159
"put": {
1111811160
"produces": [
1111911161
"application/json"

0 commit comments

Comments
 (0)