[API] on 500 error only show message if gitea in dev mode (#11641) (#11753)

6543 · web-flow · commit 99058de553a8 · 2020-06-03T22:24:47.000-04:00
* add API specific InternalServerError()

* return 500 error msg only if not Production mode

* rm unnessesary change
diff --git a/modules/context/api.go b/modules/context/api.go
@@ -77,6 +77,10 @@ func (ctx *APIContext) Error(status int, title string, obj interface{}) {
 
 	if status == http.StatusInternalServerError {
 		log.ErrorWithSkip(1, "%s: %s", title, message)
+
+		if macaron.Env == macaron.PROD {
+			message = ""
+		}
 	}
 
 	ctx.JSON(status, APIError{

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,10 @@ func (ctx *APIContext) Error(status int, title string, obj interface{}) {`
`77`	`77`
`78`	`78`	`if status == http.StatusInternalServerError {`
`79`	`79`	`log.ErrorWithSkip(1, "%s: %s", title, message)`
	`80`	`+`
	`81`	`+ if macaron.Env == macaron.PROD {`
	`82`	`+ message = ""`
	`83`	`+ }`
`80`	`84`	`}`
`81`	`85`
`82`	`86`	`ctx.JSON(status, APIError{`