Add units concept for modulable functions of a repository (#742)

* Add units concept for modulable functions of a repository

* remove unused comment codes & fix lints and tests

* remove unused comment codes

* use struct config instead of map

* fix lint

* rm wrong files

* fix tests

Author: lunny

cmd/web.go

@@ -441,7 +441,7 @@ func runWeb(ctx *cli.Context) error {
 
 		}, func(ctx *context.Context) {
 			ctx.Data["PageIsSettings"] = true
-		})
+		}, context.UnitTypes())
 	}, reqSignIn, context.RepoAssignment(), reqRepoAdmin, context.RepoRef())
 
 	m.Get("/:username/:reponame/action/:action", reqSignIn, context.RepoAssignment(), repo.Action)
@@ -535,7 +535,7 @@ func runWeb(ctx *cli.Context) error {
 				return
 			}
 		})
-	}, reqSignIn, context.RepoAssignment(), repo.MustBeNotBare)
+	}, reqSignIn, context.RepoAssignment(), repo.MustBeNotBare, context.UnitTypes())
 
 	m.Group("/:username/:reponame", func() {
 		m.Group("", func() {
@@ -581,7 +581,7 @@ func runWeb(ctx *cli.Context) error {
 		m.Get("/commit/:sha([a-f0-9]{7,40})\\.:ext(patch|diff)", repo.RawDiff)
 
 		m.Get("/compare/:before([a-z0-9]{40})\\.\\.\\.:after([a-z0-9]{40})", repo.SetEditorconfigIfExists, repo.SetDiffViewStyle, repo.CompareDiff)
-	}, ignSignIn, context.RepoAssignment(), repo.MustBeNotBare)
+	}, ignSignIn, context.RepoAssignment(), repo.MustBeNotBare, context.UnitTypes())
 	m.Group("/:username/:reponame", func() {
 		m.Get("/stars", repo.Stars)
 		m.Get("/watchers", repo.Watchers)
@@ -591,7 +591,7 @@ func runWeb(ctx *cli.Context) error {
 		m.Group("/:reponame", func() {
 			m.Get("", repo.SetEditorconfigIfExists, repo.Home)
 			m.Get("\\.git$", repo.SetEditorconfigIfExists, repo.Home)
-		}, ignSignIn, context.RepoAssignment(true), context.RepoRef())
+		}, ignSignIn, context.RepoAssignment(true), context.RepoRef(), context.UnitTypes())
 
 		m.Group("/:reponame", func() {
 			m.Group("/info/lfs", func() {

models/migrations/migrations.go

@@ -76,10 +76,12 @@ var migrations = []Migration{
 
 	// v13 -> v14:v0.9.87
 	NewMigration("set comment updated with created", setCommentUpdatedWithCreated),
-	// v14
+	// v14 -> v15
 	NewMigration("create user column diff view style", createUserColumnDiffViewStyle),
-	// v15
+	// v15 -> v16
 	NewMigration("create user column allow create organization", createAllowCreateOrganizationColumn),
+	// V16 -> v17
+	NewMigration("create repo unit table and add units for all repos", addUnitsToTables),
 }
 
 // Migrate database to current version

models/migrations/v16.go

@@ -0,0 +1,117 @@
+package migrations
+
+import (
+	"fmt"
+	"time"
+
+	"code.gitea.io/gitea/modules/markdown"
+
+	"github.com/go-xorm/xorm"
+)
+
+// RepoUnit describes all units of a repository
+type RepoUnit struct {
+	ID          int64
+	RepoID      int64 `xorm:"INDEX(s)"`
+	Type        int   `xorm:"INDEX(s)"`
+	Index       int
+	Config      map[string]string `xorm:"JSON"`
+	CreatedUnix int64             `xorm:"INDEX CREATED"`
+	Created     time.Time         `xorm:"-"`
+}
+
+// Enumerate all the unit types
+const (
+	UnitTypeCode            = iota + 1 // 1 code
+	UnitTypeIssues                     // 2 issues
+	UnitTypePRs                        // 3 PRs
+	UnitTypeCommits                    // 4 Commits
+	UnitTypeReleases                   // 5 Releases
+	UnitTypeWiki                       // 6 Wiki
+	UnitTypeSettings                   // 7 Settings
+	UnitTypeExternalWiki               // 8 ExternalWiki
+	UnitTypeExternalTracker            // 9 ExternalTracker
+)
+
+// Repo describes a repository
+type Repo struct {
+	ID                                                                               int64
+	EnableWiki, EnableExternalWiki, EnableIssues, EnableExternalTracker, EnablePulls bool
+	ExternalWikiURL, ExternalTrackerURL, ExternalTrackerFormat, ExternalTrackerStyle string
+}
+
+func addUnitsToTables(x *xorm.Engine) error {
+	var repos []Repo
+	err := x.Table("repository").Find(&repos)
+	if err != nil {
+		return fmt.Errorf("Query repositories: %v", err)
+	}
+
+	sess := x.NewSession()
+	defer sess.Close()
+
+	if err := sess.Begin(); err != nil {
+		return err
+	}
+
+	var repoUnit RepoUnit
+	if err := sess.CreateTable(&repoUnit); err != nil {
+		return fmt.Errorf("CreateTable RepoUnit: %v", err)
+	}
+
+	if err := sess.CreateUniques(&repoUnit); err != nil {
+		return fmt.Errorf("CreateUniques RepoUnit: %v", err)
+	}
+
+	if err := sess.CreateIndexes(&repoUnit); err != nil {
+		return fmt.Errorf("CreateIndexes RepoUnit: %v", err)
+	}
+
+	for _, repo := range repos {
+		for i := 1; i <= 9; i++ {
+			if (i == UnitTypeWiki || i == UnitTypeExternalWiki) && !repo.EnableWiki {
+				continue
+			}
+			if i == UnitTypeExternalWiki && !repo.EnableExternalWiki {
+				continue
+			}
+			if i == UnitTypePRs && !repo.EnablePulls {
+				continue
+			}
+			if (i == UnitTypeIssues || i == UnitTypeExternalTracker) && !repo.EnableIssues {
+				continue
+			}
+			if i == UnitTypeExternalTracker && !repo.EnableExternalTracker {
+				continue
+			}
+
+			var config = make(map[string]string)
+			switch i {
+			case UnitTypeExternalTracker:
+				config["ExternalTrackerURL"] = repo.ExternalTrackerURL
+				config["ExternalTrackerFormat"] = repo.ExternalTrackerFormat
+				if len(repo.ExternalTrackerStyle) == 0 {
+					repo.ExternalTrackerStyle = markdown.IssueNameStyleNumeric
+				}
+				config["ExternalTrackerStyle"] = repo.ExternalTrackerStyle
+			case UnitTypeExternalWiki:
+				config["ExternalWikiURL"] = repo.ExternalWikiURL
+			}
+
+			if _, err = sess.Insert(&RepoUnit{
+				RepoID: repo.ID,
+				Type:   i,
+				Index:  i,
+				Config: config,
+			}); err != nil {
+				return fmt.Errorf("Insert repo unit: %v", err)
+			}
+		}
+	}
+
+	if err := sess.Commit(); err != nil {
+		return err
+	}
+
+	return nil
+}

models/models.go

@@ -106,6 +106,7 @@ func init() {
 		new(IssueUser),
 		new(LFSMetaObject),
 		new(TwoFactor),
+		new(RepoUnit),
 	)
 
 	gonicNames := []string{"SSL", "UID"}