add sugestions

Author: 6543

routers/user/home.go

@@ -285,9 +285,7 @@ func Issues(ctx *context.Context) {
 	}
 	opts.LabelIDs = labelIDs
 
-	if len(repoIDs) > 0 {
-		opts.RepoIDs = repoIDs
-	}
+	opts.RepoIDs = repoIDs
 
 	issues, err := models.Issues(opts)
 	if err != nil {
@@ -297,30 +295,23 @@ func Issues(ctx *context.Context) {
 
 	showReposMap := make(map[int64]*models.Repository, len(counts))
 	for repoID := range counts {
-		if repoID > 0 {
-			if _, ok := showReposMap[repoID]; !ok {
-				repo, err := models.GetRepositoryByID(repoID)
-				if models.IsErrRepoNotExist(err) {
-					ctx.NotFound("GetRepositoryByID", err)
-					return
-				} else if err != nil {
-					ctx.ServerError("GetRepositoryByID", fmt.Errorf("[%d]%v", repoID, err))
-					return
-				}
-				showReposMap[repoID] = repo
-			}
-
-			repo := showReposMap[repoID]
+		showReposMap[repoID], err = models.GetRepositoryByID(repoID)
+		if models.IsErrRepoNotExist(err) {
+			ctx.NotFound("GetRepositoryByID", err)
+			return
+		} else if err != nil {
+			ctx.ServerError("GetRepositoryByID", fmt.Errorf("[%d]%v", repoID, err))
+			return
+		}
 
-			// Check if user has access to given repository.
-			perm, err := models.GetUserRepoPermission(repo, ctxUser)
-			if err != nil {
-				ctx.ServerError("GetUserRepoPermission", fmt.Errorf("[%d]%v", repoID, err))
-				return
-			}
-			if !perm.CanRead(models.UnitTypeIssues) {
-				log.Error("User created Issues in Repository which they no longer have access to: [%d]", repoID)
-			}
+		// Check if user has access to given repository.
+		perm, err := models.GetUserRepoPermission(showReposMap[repoID], ctxUser)
+		if err != nil {
+			ctx.ServerError("GetUserRepoPermission", fmt.Errorf("[%d]%v", repoID, err))
+			return
+		}
+		if !perm.CanRead(models.UnitTypeIssues) {
+			log.Error("User created Issues in Repository which they no longer have access to: [%d]", repoID)
 		}
 	}
 

templates/user/dashboard/issues.tmpl

@@ -5,7 +5,7 @@
 		<div class="ui stackable grid">
 			<div class="four wide column">
 				<div class="ui secondary vertical filter menu">
-					<a class="{{if eq .ViewType "your_repositories"}}ui basic blue button{{end}} item" href="{{.Link}}?type=your_repositories&repos=[]&sort={{$.SortType}}&state={{.State}}">
+					<a class="{{if eq .ViewType "your_repositories"}}ui basic blue button{{end}} item" href="{{.Link}}?type=your_repositories&repos=[{{range $.RepoIDs}}{{.}}%2C{{end}}]&sort={{$.SortType}}&state={{.State}}">
 						{{.i18n.Tr "home.issues.in_your_repos"}}
 						<strong class="ui right">{{.IssueStats.YourRepositoriesCount}}</strong>
 					</a>