add id get and delete to admin auth api

Author: h0tw1r3

routers/api/v1/admin/auths.go

@@ -13,6 +13,7 @@ import (
 	api "code.gitea.io/gitea/modules/structs"
 	"code.gitea.io/gitea/modules/timeutil"
 	"code.gitea.io/gitea/modules/web"
+	auth_service "code.gitea.io/gitea/services/auth"
 	"code.gitea.io/gitea/services/auth/source/ldap"
 	"code.gitea.io/gitea/services/auth/source/oauth2"
 	"code.gitea.io/gitea/services/auth/source/pam"
@@ -47,6 +48,37 @@ func ListAuthSources(ctx *context.APIContext) {
 	ctx.JSON(http.StatusOK, result)
 }
 
+// GetAuthSource get an authentication source by id
+func GetAuthSource(ctx *context.APIContext) {
+	// swagger:operation GET /admin/auths/{id} admin adminGetAuthSource
+	// ---
+	// summary: Get an authentication source
+	// produces:
+	// - application/json
+	// parameters:
+	// - name: id
+	//   in: path
+	//   description: id of the authentication source to get
+	//   type: integer
+	//   format: int64
+	//   required: true
+	// responses:
+	//   "200":
+	//     "$ref": "#/responses/AuthSource"
+
+	source, err := auth.GetSourceByID(ctx.ParamsInt64(":id"))
+	if err != nil {
+		ctx.ServerError("auth.GetSourceByID", err)
+		return
+	}
+	result, err := convert.ToAuthSource(source)
+	if err != nil {
+		ctx.Error(http.StatusInternalServerError, "convert.ToAuthSource", err)
+		return
+	}
+	ctx.JSON(http.StatusOK, result)
+}
+
 // CreateAuthSource creates new authentication source
 func CreateAuthSource(ctx *context.APIContext) {
 	// swagger:operation POST /admin/auths admin adminCreateAuthSource
@@ -118,3 +150,38 @@ func CreateAuthSource(ctx *context.APIContext) {
 	}
 	ctx.JSON(http.StatusCreated, result)
 }
+
+// DeleteAuthSource delete an authentication source
+func DeleteAuthSource(ctx *context.APIContext) {
+	// swagger:operation DELETE /admin/auths/{id} admin adminDeleteAuthSource
+	// ---
+	// summary: Delete an authentication source
+	// produces:
+	// - application/json
+	// parameters:
+	// - name: id
+	//   in: path
+	//   description: id of the authentication source to delete
+	//   type: integer
+	//   format: int64
+	//   required: true
+	// responses:
+	//   "204":
+	//     "$ref": "#/responses/empty"
+
+	source, err := auth.GetSourceByID(ctx.ParamsInt64(":id"))
+	if err != nil {
+		ctx.ServerError("auth.GetSourceByID", err)
+		return
+	}
+
+	if err = auth_service.DeleteSource(source); err != nil {
+		if auth.IsErrSourceInUse(err) {
+			ctx.Error(http.StatusInternalServerError, "auth_service.DeleteSource", err)
+		} else {
+			ctx.Error(http.StatusInternalServerError, "auth_service.DeleteSource", err)
+		}
+		return
+	}
+	ctx.Status(http.StatusNoContent)
+}

routers/api/v1/api.go

@@ -1233,8 +1233,10 @@ func Routes(ctx gocontext.Context) *web.Route {
 
 		m.Group("/admin", func() {
 			m.Group("/auths", func() {
-				m.Get("", admin.ListAuthSources)
-				m.Post("", bind(api.CreateAuthSource{}), admin.CreateAuthSource)
+				m.Combo("").Get(admin.ListAuthSources).
+					Post(bind(api.CreateAuthSource{}), admin.CreateAuthSource)
+				m.Combo("/{id}").Get(admin.GetAuthSource).
+					Delete(admin.DeleteAuthSource)
 			})
 			m.Group("/cron", func() {
 				m.Get("", admin.ListCronTasks)

templates/swagger/v1_json.tmpl

@@ -125,6 +125,58 @@
         }
       }
     },
+    "/admin/auths/{id}": {
+      "get": {
+        "produces": [
+          "application/json"
+        ],
+        "tags": [
+          "admin"
+        ],
+        "summary": "Get an authentication source",
+        "operationId": "adminGetAuthSource",
+        "parameters": [
+          {
+            "type": "integer",
+            "format": "int64",
+            "description": "id of the authentication source to get",
+            "name": "id",
+            "in": "path",
+            "required": true
+          }
+        ],
+        "responses": {
+          "200": {
+            "$ref": "#/responses/AuthSource"
+          }
+        }
+      },
+      "delete": {
+        "produces": [
+          "application/json"
+        ],
+        "tags": [
+          "admin"
+        ],
+        "summary": "Delete an authentication source",
+        "operationId": "adminDeleteAuthSource",
+        "parameters": [
+          {
+            "type": "integer",
+            "format": "int64",
+            "description": "id of the authentication source to delete",
+            "name": "id",
+            "in": "path",
+            "required": true
+          }
+        ],
+        "responses": {
+          "204": {
+            "$ref": "#/responses/empty"
+          }
+        }
+      }
+    },
     "/admin/cron": {
       "get": {
         "produces": [
@@ -20242,12 +20294,6 @@
         }
       }
     },
-    "CreateAuthSource": {
-      "description": "CreateAuthSource",
-      "schema": {
-        "$ref": "#/definitions/CreateAuthSource"
-      }
-    },
     "Branch": {
       "description": "Branch",
       "schema": {
@@ -20405,6 +20451,12 @@
         "$ref": "#/definitions/ContentsResponse"
       }
     },
+    "CreateAuthSource": {
+      "description": "CreateAuthSource",
+      "schema": {
+        "$ref": "#/definitions/CreateAuthSource"
+      }
+    },
     "CronList": {
       "description": "CronList",
       "schema": {