Don't WARN log UserNotExist errors on ExternalUserLogin failure (#16238)

zeripath · web-flow · commit 5f2ef17fdb75 · 2021-06-23T17:41:39.000-04:00
Instead log these at debug - with warn logging for other errors. Fix #16235 Signed-off-by: Andrew Thornton <art27@cantab.net>
diff --git a/models/login_source.go b/models/login_source.go
@@ -856,7 +856,11 @@ func UserSignIn(username, password string) (*User, error) {
 			return authUser, nil
 		}
 
-		log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)
+		if IsErrUserNotExist(err) {
+			log.Debug("Failed to login '%s' via '%s': %v", username, source.Name, err)
+		} else {
+			log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)
+		}
 	}
 
 	return nil, ErrUserNotExist{user.ID, user.Name, 0}

Original file line number	Diff line number	Diff line change
`@@ -856,7 +856,11 @@ func UserSignIn(username, password string) (*User, error) {`
`856`	`856`	`return authUser, nil`
`857`	`857`	`}`
`858`	`858`
`859`		`- log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)`
	`859`	`+ if IsErrUserNotExist(err) {`
	`860`	`+ log.Debug("Failed to login '%s' via '%s': %v", username, source.Name, err)`
	`861`	`+ } else {`
	`862`	`+ log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)`
	`863`	`+ }`
`860`	`864`	`}`
`861`	`865`
`862`	`866`	`return nil, ErrUserNotExist{user.ID, user.Name, 0}`