Skip to content

Commit 5af08a9

Browse files
authored
Merge branch 'master' into pr-squash-comment
2 parents 0915e52 + 4aabbac commit 5af08a9

File tree

303 files changed

+6331
-4290
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

303 files changed

+6331
-4290
lines changed

.drone.yml

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,16 @@ steps:
3333
GOSUMDB: sum.golang.org
3434
TAGS: bindata sqlite sqlite_unlock_notify
3535

36+
- name: lint-backend-gogit
37+
pull: always
38+
image: golang:1.15
39+
commands:
40+
- make lint-backend
41+
environment:
42+
GOPROXY: https://goproxy.cn # proxy.golang.org is blocked in China, this proxy is not
43+
GOSUMDB: sum.golang.org
44+
TAGS: bindata gogit sqlite sqlite_unlock_notify
45+
3646
- name: checks-frontend
3747
image: node:14
3848
commands:
@@ -69,7 +79,7 @@ steps:
6979
GOPROXY: off
7080
GOOS: linux
7181
GOARCH: arm64
72-
TAGS: bindata
82+
TAGS: bindata gogit
7383
commands:
7484
- make backend # test cross compile
7585
- rm ./gitea # clean
@@ -173,6 +183,17 @@ steps:
173183
GITHUB_READ_TOKEN:
174184
from_secret: github_read_token
175185

186+
- name: unit-test-gogit
187+
pull: always
188+
image: golang:1.15
189+
commands:
190+
- make unit-test-coverage test-check
191+
environment:
192+
GOPROXY: off
193+
TAGS: bindata gogit sqlite sqlite_unlock_notify
194+
GITHUB_READ_TOKEN:
195+
from_secret: github_read_token
196+
176197
- name: test-mysql
177198
image: golang:1.15
178199
commands:
@@ -305,7 +326,8 @@ steps:
305326
- timeout -s ABRT 40m make test-sqlite-migration test-sqlite
306327
environment:
307328
GOPROXY: off
308-
TAGS: bindata
329+
TAGS: bindata gogit sqlite sqlite_unlock_notify
330+
TEST_TAGS: gogit sqlite sqlite_unlock_notify
309331
USE_REPO_TEST_DIR: 1
310332
depends_on:
311333
- build
@@ -318,7 +340,8 @@ steps:
318340
- timeout -s ABRT 40m make test-pgsql-migration test-pgsql
319341
environment:
320342
GOPROXY: off
321-
TAGS: bindata
343+
TAGS: bindata gogit
344+
TEST_TAGS: gogit
322345
TEST_LDAP: 1
323346
USE_REPO_TEST_DIR: 1
324347
depends_on:

.github/issue_template.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22

33
<!--
44
1. Please speak English, this is the language all maintainers can speak and write.
5-
2. Please ask questions or configuration/deploy problems on our Discord
5+
2. Please ask questions or configuration/deploy problems on our Discord
66
server (https://discord.gg/gitea) or forum (https://discourse.gitea.io).
77
3. Please take a moment to check that your issue doesn't already exist.
8-
4. Please give all relevant information below for bug reports, because
8+
4. Make sure it's not mentioned in the FAQ (https://docs.gitea.io/en-us/faq)
9+
5. Please give all relevant information below for bug reports, because
910
incomplete details will be handled as an invalid report.
1011
-->
1112

MAINTAINERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,4 @@ David Svantesson <[email protected]> (@davidsvantesson)
3939
CirnoT <[email protected]> (@CirnoT)
4040
a1012112796 <[email protected]> (@a1012112796)
4141
Karl Heinz Marbaise <[email protected]> (@khmarbaise)
42+
Norwin Roosen <[email protected]> (@noerw)

Makefile

Lines changed: 35 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
ifeq ($(USE_REPO_TEST_DIR),1)
32

43
# This rule replaces the whole Makefile when we're trying to use /tmp repository temporary files
@@ -110,7 +109,10 @@ TAGS ?=
110109
TAGS_SPLIT := $(subst $(COMMA), ,$(TAGS))
111110
TAGS_EVIDENCE := $(MAKE_EVIDENCE_DIR)/tags
112111

112+
TEST_TAGS ?= sqlite sqlite_unlock_notify
113+
113114
GO_DIRS := cmd integrations models modules routers build services vendor tools
115+
114116
GO_SOURCES := $(wildcard *.go)
115117
GO_SOURCES += $(shell find $(GO_DIRS) -type f -name "*.go" -not -path modules/options/bindata.go -not -path modules/public/bindata.go -not -path modules/templates/bindata.go)
116118

@@ -339,8 +341,8 @@ watch-backend: go-check
339341

340342
.PHONY: test
341343
test:
342-
@echo "Running go test..."
343-
@$(GO) test $(GOTESTFLAGS) -mod=vendor -tags='sqlite sqlite_unlock_notify' $(GO_PACKAGES)
344+
@echo "Running go test with -tags '$(TEST_TAGS)'..."
345+
@$(GO) test $(GOTESTFLAGS) -mod=vendor -tags='$(TEST_TAGS)' $(GO_PACKAGES)
344346

345347
.PHONY: test-check
346348
test-check:
@@ -356,17 +358,17 @@ test-check:
356358

357359
.PHONY: test\#%
358360
test\#%:
359-
@echo "Running go test..."
360-
@$(GO) test -mod=vendor -tags='sqlite sqlite_unlock_notify' -run $(subst .,/,$*) $(GO_PACKAGES)
361+
@echo "Running go test with -tags '$(TEST_TAGS)'..."
362+
@$(GO) test -mod=vendor -tags='$(TEST_TAGS)' -run $(subst .,/,$*) $(GO_PACKAGES)
361363

362364
.PHONY: coverage
363365
coverage:
364366
GO111MODULE=on $(GO) run -mod=vendor build/gocovmerge.go integration.coverage.out $(shell find . -type f -name "coverage.out") > coverage.all
365367

366368
.PHONY: unit-test-coverage
367369
unit-test-coverage:
368-
@echo "Running unit-test-coverage..."
369-
@$(GO) test $(GOTESTFLAGS) -mod=vendor -tags='sqlite sqlite_unlock_notify' -cover -coverprofile coverage.out $(GO_PACKAGES) && echo "\n==>\033[32m Ok\033[m\n" || exit 1
370+
@echo "Running unit-test-coverage -tags '$(TEST_TAGS)'..."
371+
@$(GO) test $(GOTESTFLAGS) -mod=vendor -tags='$(TEST_TAGS)' -cover -coverprofile coverage.out $(GO_PACKAGES) && echo "\n==>\033[32m Ok\033[m\n" || exit 1
370372

371373
.PHONY: vendor
372374
vendor:
@@ -387,15 +389,15 @@ generate-ini-sqlite:
387389

388390
.PHONY: test-sqlite
389391
test-sqlite: integrations.sqlite.test generate-ini-sqlite
390-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test
392+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test
391393

392394
.PHONY: test-sqlite\#%
393395
test-sqlite\#%: integrations.sqlite.test generate-ini-sqlite
394-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test -test.run $(subst .,/,$*)
396+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test -test.run $(subst .,/,$*)
395397

396398
.PHONY: test-sqlite-migration
397399
test-sqlite-migration: migrations.sqlite.test generate-ini-sqlite
398-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/sqlite.ini ./migrations.sqlite.test
400+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/sqlite.ini ./migrations.sqlite.test
399401

400402
generate-ini-mysql:
401403
sed -e 's|{{TEST_MYSQL_HOST}}|${TEST_MYSQL_HOST}|g' \
@@ -407,15 +409,15 @@ generate-ini-mysql:
407409

408410
.PHONY: test-mysql
409411
test-mysql: integrations.mysql.test generate-ini-mysql
410-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test
412+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test
411413

412414
.PHONY: test-mysql\#%
413415
test-mysql\#%: integrations.mysql.test generate-ini-mysql
414-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test -test.run $(subst .,/,$*)
416+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test -test.run $(subst .,/,$*)
415417

416418
.PHONY: test-mysql-migration
417419
test-mysql-migration: migrations.mysql.test generate-ini-mysql
418-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./migrations.mysql.test
420+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql.ini ./migrations.mysql.test
419421

420422
generate-ini-mysql8:
421423
sed -e 's|{{TEST_MYSQL8_HOST}}|${TEST_MYSQL8_HOST}|g' \
@@ -427,15 +429,15 @@ generate-ini-mysql8:
427429

428430
.PHONY: test-mysql8
429431
test-mysql8: integrations.mysql8.test generate-ini-mysql8
430-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql8.ini ./integrations.mysql8.test
432+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql8.ini ./integrations.mysql8.test
431433

432434
.PHONY: test-mysql8\#%
433435
test-mysql8\#%: integrations.mysql8.test generate-ini-mysql8
434-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql8.ini ./integrations.mysql8.test -test.run $(subst .,/,$*)
436+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql8.ini ./integrations.mysql8.test -test.run $(subst .,/,$*)
435437

436438
.PHONY: test-mysql8-migration
437439
test-mysql8-migration: migrations.mysql8.test generate-ini-mysql8
438-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql8.ini ./migrations.mysql8.test
440+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql8.ini ./migrations.mysql8.test
439441

440442
generate-ini-pgsql:
441443
sed -e 's|{{TEST_PGSQL_HOST}}|${TEST_PGSQL_HOST}|g' \
@@ -448,15 +450,15 @@ generate-ini-pgsql:
448450

449451
.PHONY: test-pgsql
450452
test-pgsql: integrations.pgsql.test generate-ini-pgsql
451-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test
453+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test
452454

453455
.PHONY: test-pgsql\#%
454456
test-pgsql\#%: integrations.pgsql.test generate-ini-pgsql
455-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test -test.run $(subst .,/,$*)
457+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test -test.run $(subst .,/,$*)
456458

457459
.PHONY: test-pgsql-migration
458460
test-pgsql-migration: migrations.pgsql.test generate-ini-pgsql
459-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/pgsql.ini ./migrations.pgsql.test
461+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/pgsql.ini ./migrations.pgsql.test
460462

461463
generate-ini-mssql:
462464
sed -e 's|{{TEST_MSSQL_HOST}}|${TEST_MSSQL_HOST}|g' \
@@ -468,35 +470,35 @@ generate-ini-mssql:
468470

469471
.PHONY: test-mssql
470472
test-mssql: integrations.mssql.test generate-ini-mssql
471-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test
473+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test
472474

473475
.PHONY: test-mssql\#%
474476
test-mssql\#%: integrations.mssql.test generate-ini-mssql
475-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test -test.run $(subst .,/,$*)
477+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test -test.run $(subst .,/,$*)
476478

477479
.PHONY: test-mssql-migration
478480
test-mssql-migration: migrations.mssql.test generate-ini-mssql
479-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mssql.ini ./migrations.mssql.test -test.failfast
481+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mssql.ini ./migrations.mssql.test -test.failfast
480482

481483
.PHONY: bench-sqlite
482484
bench-sqlite: integrations.sqlite.test generate-ini-sqlite
483-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
485+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
484486

485487
.PHONY: bench-mysql
486488
bench-mysql: integrations.mysql.test generate-ini-mysql
487-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
489+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql.ini ./integrations.mysql.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
488490

489491
.PHONY: bench-mssql
490492
bench-mssql: integrations.mssql.test generate-ini-mssql
491-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
493+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mssql.ini ./integrations.mssql.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
492494

493495
.PHONY: bench-pgsql
494496
bench-pgsql: integrations.pgsql.test generate-ini-pgsql
495-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
497+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/pgsql.ini ./integrations.pgsql.test -test.cpuprofile=cpu.out -test.run DontRunTests -test.bench .
496498

497499
.PHONY: integration-test-coverage
498500
integration-test-coverage: integrations.cover.test generate-ini-mysql
499-
GITEA_ROOT=${CURDIR} GITEA_CONF=integrations/mysql.ini ./integrations.cover.test -test.coverprofile=integration.coverage.out
501+
GITEA_ROOT="$(CURDIR)" GITEA_CONF=integrations/mysql.ini ./integrations.cover.test -test.coverprofile=integration.coverage.out
500502

501503
integrations.mysql.test: git-check $(GO_SOURCES)
502504
$(GO) test $(GOTESTFLAGS) -mod=vendor -c code.gitea.io/gitea/integrations -o integrations.mysql.test
@@ -511,7 +513,7 @@ integrations.mssql.test: git-check $(GO_SOURCES)
511513
$(GO) test $(GOTESTFLAGS) -mod=vendor -c code.gitea.io/gitea/integrations -o integrations.mssql.test
512514

513515
integrations.sqlite.test: git-check $(GO_SOURCES)
514-
$(GO) test $(GOTESTFLAGS) -mod=vendor -c code.gitea.io/gitea/integrations -o integrations.sqlite.test -tags 'sqlite sqlite_unlock_notify'
516+
$(GO) test $(GOTESTFLAGS) -mod=vendor -c code.gitea.io/gitea/integrations -o integrations.sqlite.test -tags '$(TEST_TAGS)'
515517

516518
integrations.cover.test: git-check $(GO_SOURCES)
517519
$(GO) test $(GOTESTFLAGS) -mod=vendor -c code.gitea.io/gitea/integrations -coverpkg $(shell echo $(GO_PACKAGES) | tr ' ' ',') -o integrations.cover.test
@@ -534,7 +536,7 @@ migrations.mssql.test: $(GO_SOURCES)
534536

535537
.PHONY: migrations.sqlite.test
536538
migrations.sqlite.test: $(GO_SOURCES)
537-
$(GO) test $(GOTESTFLAGS) -c code.gitea.io/gitea/integrations/migration-test -o migrations.sqlite.test -tags 'sqlite sqlite_unlock_notify'
539+
$(GO) test $(GOTESTFLAGS) -c code.gitea.io/gitea/integrations/migration-test -o migrations.sqlite.test -tags '$(TEST_TAGS)'
538540

539541
.PHONY: check
540542
check: test
@@ -694,11 +696,10 @@ generate-license:
694696
generate-gitignore:
695697
GO111MODULE=on $(GO) run build/generate-gitignores.go
696698

697-
698699
.PHONY: generate-images
699700
generate-images:
700-
npm install --no-save --no-package-lock xmldom fabric imagemin-zopfli
701-
node build/generate-images.js
701+
npm install --no-save --no-package-lock fabric imagemin-zopfli
702+
node build/generate-images.js $(TAGS)
702703

703704
.PHONY: pr\#%
704705
pr\#%: clean-all
@@ -710,7 +711,7 @@ golangci-lint:
710711
export BINARY="golangci-lint"; \
711712
curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(GOPATH)/bin v1.31.0; \
712713
fi
713-
golangci-lint run --timeout 5m
714+
golangci-lint run --timeout 10m
714715

715716
.PHONY: docker
716717
docker:
@@ -719,7 +720,7 @@ docker:
719720

720721
.PHONY: docker-build
721722
docker-build:
722-
docker run -ti --rm -v $(CURDIR):/srv/app/src/code.gitea.io/gitea -w /srv/app/src/code.gitea.io/gitea -e TAGS="bindata $(TAGS)" LDFLAGS="$(LDFLAGS)" CGO_EXTRA_CFLAGS="$(CGO_EXTRA_CFLAGS)" webhippie/golang:edge make clean build
723+
docker run -ti --rm -v "$(CURDIR):/srv/app/src/code.gitea.io/gitea" -w /srv/app/src/code.gitea.io/gitea -e TAGS="bindata $(TAGS)" LDFLAGS="$(LDFLAGS)" CGO_EXTRA_CFLAGS="$(CGO_EXTRA_CFLAGS)" webhippie/golang:edge make clean build
723724

724725
# This endif closes the if at the top of the file
725726
endif

0 commit comments

Comments
 (0)