Skip to content

Commit 58646ca

Browse files
authored
Move sans-serif fallback font higher than emoji fonts (#15855)
The Tor browser does not use the system-ui font and no other fonts in the stack match its default fonts. In fact it is possible that it will in future only match generic fonts. This means that all rendering will first try the emoji fonts before falling back to the sans-serif font for glyphs. In this case has the emoji fall back fonts for Tor contains empty glyphs for numbers - in order to protect privacy - and leads to numbers being rendered as empty glyphs. This is clearly not ideal and whilst we could use the Arimo font - as I state above I suspect that Tor will eventually ban detecting this and we should instead move the sans-serif font higher in the stack so that it matches before the emoji fonts. Partial fix of #15844 Signed-off-by: Andrew Thornton <[email protected]>
1 parent e0c93fe commit 58646ca

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

web_src/less/_base.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@
121121
}
122122

123123
:root * {
124-
--fonts-regular: var(--fonts-override, var(--fonts-proportional)), "Noto Sans", "Liberation Sans", var(--fonts-emoji), sans-serif;
124+
--fonts-regular: var(--fonts-override, var(--fonts-proportional)), "Noto Sans", "Liberation Sans", sans-serif, var(--fonts-emoji);
125125
}
126126

127127
textarea {

0 commit comments

Comments
 (0)