fix: no longer using the main repo's env

Author: BLumia

models/helper_environment.go

@@ -43,6 +43,11 @@ func PushingEnvironment(doer *User, repo *Repository) []string {
 	return FullPushingEnvironment(doer, doer, repo, repo.Name, 0)
 }
 
+// WikiPushingEnvironment returns an os environment for wiki repo
+func WikiPushingEnvironment(doer *User, repo *Repository) []string {
+	return FullPushingEnvironment(doer, doer, repo, repo.Name+".wiki", 0)
+}
+
 // FullPushingEnvironment returns an os environment to allow hooks to work on push
 func FullPushingEnvironment(author, committer *User, repo *Repository, repoName string, prID int64) []string {
 	isWiki := "false"

modules/repofiles/temp_repo.go

@@ -270,13 +270,15 @@ func (t *TemporaryUploadRepository) CommitTreeWithDate(author, committer *models
 
 // Push the provided commitHash to the repository branch by the provided user
 func (t *TemporaryUploadRepository) push(doer *models.User, commitHash string, branch string, isWiki bool) error {
+	// Because calls hooks we need to pass in the environment
+	env := models.PushingEnvironment(doer, t.repo)
 	repoPath := t.repo.RepoPath()
+
 	if isWiki {
 		repoPath = t.repo.WikiPath()
+		env = models.WikiPushingEnvironment(doer, t.repo)
 	}
 
-	// Because calls hooks we need to pass in the environment
-	env := models.PushingEnvironment(doer, t.repo)
 	if err := git.Push(t.basePath, git.PushOptions{
 		Remote: repoPath,
 		Branch: strings.TrimSpace(commitHash) + ":refs/heads/" + strings.TrimSpace(branch),

routers/repo/wiki.go

@@ -707,7 +707,10 @@ func UploadWikiFilePost(ctx *context.Context, form auth.UploadWikiFileForm) {
 		Message:      message,
 		Files:        form.Files,
 	}); err != nil {
+		// FIXME: it will get a "The process cannot access the file because it is being used by another process." error when try to remove
+		//        the uploaded cache file. Upload is successed anyway, but still need to fix this one.
 		log.Error("Error during upload to repo %-v : %v", ctx.Repo.Repository, err)
+		ctx.RenderWithErr(ctx.Tr("repo.editor.unable_to_upload_files", "_media", err), tplWikiUpload, &form)
 		return
 	}
 

services/wiki/wiki.go

@@ -209,13 +209,7 @@ func updateWikiPage(doer *models.User, repo *models.Repository, oldWikiName, new
 	if err := git.Push(basePath, git.PushOptions{
 		Remote: "origin",
 		Branch: fmt.Sprintf("%s:%s%s", commitHash.String(), git.BranchPrefix, "master"),
-		Env: models.FullPushingEnvironment(
-			doer,
-			doer,
-			repo,
-			repo.Name+".wiki",
-			0,
-		),
+		Env:    models.WikiPushingEnvironment(doer, repo),
 	}); err != nil {
 		log.Error("%v", err)
 		if git.IsErrPushOutOfDate(err) || git.IsErrPushRejected(err) {