Skip to content

Commit 48e3e38

Browse files
wxiaoguangGiteaBot
wxiaoguang
and
GiteaBot
authored
Clean up polluted styles and remove dead CSS code (#24497)
Follow #24393 The funny history: * At the beginning, `.ui.message` was polluted by `text-align: center` * Then people do `<div class="ui ... message text left">` * But `.ui.left` is polluted by `float: left` * Then people do `#xxx .ui.message { width: 100% !important;}` The code just becomes more and more hacky. After removing the pollution, everything becomes clear and straight. And, this PR also does: 1. Remove the `package.css`, its styles could be provided by `top aligned` 2. Remove `#avatar-arrow`, dead code Screenshot: ![image](https://user-images.githubusercontent.com/2114189/235862130-a9eb5d8f-7d01-457c-99f7-21d0abc3075e.png) ![image](https://user-images.githubusercontent.com/2114189/235862222-139709a7-95c2-4f89-a40f-100b2d76d9bb.png) Co-authored-by: Giteabot <[email protected]>
1 parent e9b3925 commit 48e3e38

File tree

11 files changed

+17
-58
lines changed

11 files changed

+17
-58
lines changed

‎templates/base/alert.tmpl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
{{if .Flash.ErrorMsg}}
2-
<div class="ui negative message flash-error">
2+
<div class="ui negative message flash-message flash-error">
33
<p>{{.Flash.ErrorMsg | Str2html}}</p>
44
</div>
55
{{end}}
66
{{if .Flash.SuccessMsg}}
7-
<div class="ui positive message flash-success">
7+
<div class="ui positive message flash-message flash-success">
88
<p>{{.Flash.SuccessMsg | Str2html}}</p>
99
</div>
1010
{{end}}
1111
{{if .Flash.InfoMsg}}
12-
<div class="ui info message flash-info">
12+
<div class="ui info message flash-message flash-info">
1313
<p>{{.Flash.InfoMsg | Str2html}}</p>
1414
</div>
1515
{{end}}
1616
{{if .Flash.WarningMsg}}
17-
<div class="ui warning message flash-warning">
17+
<div class="ui warning message flash-message flash-warning">
1818
<p>{{.Flash.WarningMsg | Str2html}}</p>
1919
</div>
2020
{{end}}

‎templates/package/content/container.tmpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
{{if .PackageDescriptor.Metadata.Labels}}
7070
<h4 class="ui top attached header">{{.locale.Tr "packages.container.labels"}}</h4>
7171
<div class="ui attached segment">
72-
<table class="ui very basic compact table container-labels">
72+
<table class="ui very basic compact table">
7373
<thead>
7474
<tr>
7575
<th>{{.locale.Tr "packages.container.labels.key"}}</th>
@@ -79,8 +79,8 @@
7979
<tbody>
8080
{{range $key, $value := .PackageDescriptor.Metadata.Labels}}
8181
<tr>
82-
<td>{{$key}}</td>
83-
<td>{{$value}}</td>
82+
<td class="top aligned">{{$key}}</td>
83+
<td class="gt-word-break">{{$value}}</td>
8484
</tr>
8585
{{end}}
8686
</tbody>

‎templates/package/settings.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
{{.locale.Tr "packages.settings.delete"}}
5252
</div>
5353
<div class="content">
54-
<div class="ui warning message text left gt-word-break">
54+
<div class="ui warning message gt-word-break">
5555
{{.locale.Tr "packages.settings.delete.notice" .PackageDescriptor.Package.Name .PackageDescriptor.Version.Version}}
5656
</div>
5757
<form class="ui form" action="{{.Link}}" method="post">

‎templates/repo/issue/view_content/pull.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
{{$.locale.Tr "repo.issues.dismiss_review"}}
4848
</div>
4949
<div class="content">
50-
<div class="ui warning message text left">
50+
<div class="ui warning message">
5151
{{$.locale.Tr "repo.issues.dismiss_review_warning"}}
5252
</div>
5353
<form class="ui form dismiss-review-form" id="dismiss-review-{{.Review.ID}}" action="{{$.RepoLink}}/issues/dismiss_review" method="post">

‎templates/repo/issue/view_content/sidebar.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@
560560
{{end}}
561561
</div>
562562
<div class="content">
563-
<div class="ui warning message text left">
563+
<div class="ui warning message">
564564
{{if .Issue.IsLocked}}
565565
{{.locale.Tr "repo.issues.unlock.notice_1"}}<br>
566566
{{.locale.Tr "repo.issues.unlock.notice_2"}}<br>

‎templates/repo/migrate/migrating.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
{{.locale.Tr "repo.settings.delete"}}
5151
</div>
5252
<div class="content">
53-
<div class="ui warning message text left">
53+
<div class="ui warning message">
5454
{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}<br>
5555
{{.locale.Tr "repo.settings.delete_notices_2" .Repository.FullName | Safe}}
5656
{{if .Repository.NumForks}}<br>

‎templates/repo/settings/options.tmpl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -803,7 +803,7 @@
803803
{{.locale.Tr "repo.settings.convert"}}
804804
</div>
805805
<div class="content">
806-
<div class="ui warning message text left">
806+
<div class="ui warning message">
807807
{{.locale.Tr "repo.settings.convert_notices_1"}}
808808
</div>
809809
<form class="ui form" action="{{.Link}}" method="post">
@@ -834,7 +834,7 @@
834834
{{.locale.Tr "repo.settings.convert_fork"}}
835835
</div>
836836
<div class="content">
837-
<div class="ui warning message text left">
837+
<div class="ui warning message">
838838
{{.locale.Tr "repo.settings.convert_fork_notices_1"}}
839839
</div>
840840
<form class="ui form" action="{{.Link}}" method="post">
@@ -864,7 +864,7 @@
864864
{{.locale.Tr "repo.settings.transfer"}}
865865
</div>
866866
<div class="content">
867-
<div class="ui warning message text left">
867+
<div class="ui warning message">
868868
{{.locale.Tr "repo.settings.transfer_notices_1"}} <br>
869869
{{.locale.Tr "repo.settings.transfer_notices_2"}} <br>
870870
{{.locale.Tr "repo.settings.transfer_notices_3"}}
@@ -900,7 +900,7 @@
900900
{{.locale.Tr "repo.settings.delete"}}
901901
</div>
902902
<div class="content">
903-
<div class="ui warning message text left">
903+
<div class="ui warning message">
904904
{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}<br>
905905
{{.locale.Tr "repo.settings.delete_notices_2" .Repository.FullName | Safe}}
906906
{{if .Repository.NumForks}}<br>
@@ -935,7 +935,7 @@
935935
{{.locale.Tr "repo.settings.wiki_delete"}}
936936
</div>
937937
<div class="content">
938-
<div class="ui warning message text left">
938+
<div class="ui warning message">
939939
{{.locale.Tr "repo.settings.delete_notices_1" | Safe}}<br>
940940
{{.locale.Tr "repo.settings.wiki_delete_notices_1" .Repository.Name | Safe}}
941941
</div>

‎web_src/css/base.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1556,7 +1556,7 @@ img.ui.avatar,
15561556
vertical-align: middle;
15571557
}
15581558

1559-
.ui .message {
1559+
.ui .message.flash-message {
15601560
text-align: center;
15611561
}
15621562

‎web_src/css/index.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,5 @@
4141
@import "./admin.css";
4242
@import "./explore.css";
4343
@import "./review.css";
44-
@import "./package.css";
4544
@import "./runner.css";
4645
@import "./helpers.css";

‎web_src/css/package.css

Lines changed: 0 additions & 7 deletions
This file was deleted.

‎web_src/css/repository.css

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -2600,39 +2600,6 @@
26002600
height: 15px;
26012601
}
26022602

2603-
#avatar-arrow::before,
2604-
#avatar-arrow::after {
2605-
right: 100%;
2606-
top: 20px;
2607-
border: solid transparent;
2608-
content: " ";
2609-
height: 0;
2610-
width: 0;
2611-
position: absolute;
2612-
pointer-events: none;
2613-
}
2614-
2615-
#avatar-arrow::before {
2616-
border-right-color: var(--color-secondary);
2617-
border-width: 9px;
2618-
margin-top: -9px;
2619-
}
2620-
2621-
#avatar-arrow::after {
2622-
border-right-color: var(--color-box-header);
2623-
border-width: 8px;
2624-
margin-top: -8px;
2625-
}
2626-
2627-
#transfer-repo-modal .ui.message,
2628-
#delete-repo-modal .ui.message,
2629-
#delete-wiki-modal .ui.message,
2630-
#convert-fork-repo-modal .ui.message,
2631-
#convert-mirror-repo-modal .ui.message,
2632-
#fork-repo-modal .ui.message {
2633-
width: 100% !important;
2634-
}
2635-
26362603
.tab-size-1 {
26372604
tab-size: 1 !important;
26382605
-moz-tab-size: 1 !important;

0 commit comments

Comments
 (0)