fine tune variable name and comments

Author: wxiaoguang

modules/markup/html.go

@@ -106,6 +106,7 @@ var filesChangedFullPatternOnce sync.Once
 
 func getIssueFullPattern() *regexp.Regexp {
 	issueFullPatternOnce.Do(func() {
+		// example: https://domain/org/repo/pulls/27#hash
 		issueFullPattern = regexp.MustCompile(regexp.QuoteMeta(setting.AppURL) +
 			`[\w_.-]+/[\w_.-]+/(?:issues|pulls)/((?:\w{1,10}-)?[1-9][0-9]*)([\?|#](\S+)?)?\b`)
 	})
@@ -114,6 +115,7 @@ func getIssueFullPattern() *regexp.Regexp {
 
 func getFilesChangedFullPattern() *regexp.Regexp {
 	filesChangedFullPatternOnce.Do(func() {
+		// example: https://domain/org/repo/pulls/27/files#hash
 		filesChangedFullPattern = regexp.MustCompile(regexp.QuoteMeta(setting.AppURL) +
 			`[\w_.-]+/[\w_.-]+/pulls/((?:\w{1,10}-)?[1-9][0-9]*)/files([\?|#](\S+)?)?\b`)
 	})
@@ -816,15 +818,13 @@ func fullIssuePatternProcessor(ctx *RenderContext, node *html.Node) {
 		}
 
 		mDiffView := getFilesChangedFullPattern().FindStringSubmatchIndex(node.Data)
-		// if the link is from "Files Changed" tab in pull requests https://domain/org/repo/pulls/27/files (aka: the files diff view)
-		// leave it as it is
+		// leave it as it is if the link is from "Files Changed" tab in PR Diff View https://domain/org/repo/pulls/27/files
 		if mDiffView != nil {
 			return
 		}
 
 		link := node.Data[m[0]:m[1]]
-		id := "#" + node.Data[m[2]:m[3]]
-		text := id
+		text := "#" + node.Data[m[2]:m[3]]
 		// if m[4] and m[5] is not -1, then link is to a comment
 		// indicate that in the text by appending (comment)
 		if m[4] != -1 && m[5] != -1 {

web_src/js/features/comp/MarkupContentPreview.js

@@ -1,6 +1,6 @@
 import $ from 'jquery';
 import {initMarkupContent} from '../../markup/content.js';
-import {attachTippyToRefIssues} from '../contextpopup.js';
+import {attachRefIssueContextPopup} from '../contextpopup.js';
 
 const {csrfToken} = window.config;
 
@@ -18,7 +18,7 @@ export function initCompMarkupContentPreviewTab($form) {
       const $previewPanel = $form.find(`.tab[data-tab="${$tabMenu.data('preview')}"]`);
       $previewPanel.html(data);
       const refIssues = $previewPanel.find('p .ref-issue');
-      attachTippyToRefIssues(refIssues);
+      attachRefIssueContextPopup(refIssues);
       initMarkupContent();
     });
   });

web_src/js/features/contextpopup.js

@@ -6,10 +6,10 @@ import {createTippy} from '../modules/tippy.js';
 
 export function initContextPopups() {
   const refIssues = $('.ref-issue');
-  attachTippyToRefIssues(refIssues);
+  attachRefIssueContextPopup(refIssues);
 }
 
-export function attachTippyToRefIssues(refIssues) {
+export function attachRefIssueContextPopup(refIssues) {
   if (!refIssues.length) return;
   refIssues.each(function () {
     if ($(this).hasClass('ref-external-issue')) {

web_src/js/features/repo-legacy.js

@@ -26,7 +26,7 @@ import {initCompReactionSelector} from './comp/ReactionSelector.js';
 import {initRepoSettingBranches} from './repo-settings.js';
 import {initRepoPullRequestMergeForm} from './repo-issue-pr-form.js';
 import {hideElem, showElem} from '../utils/dom.js';
-import {attachTippyToRefIssues} from './contextpopup.js';
+import {attachRefIssueContextPopup} from './contextpopup.js';
 
 const {csrfToken} = window.config;
 
@@ -440,10 +440,8 @@ async function onEditContent(event) {
         } else {
           $renderContent.html(data.content);
           $rawContent.text($textarea.val());
-          // check if the content contains ref-issue
-          // if there are ref issues, attach the tippy
           const refIssues = $renderContent.find('p .ref-issue');
-          attachTippyToRefIssues(refIssues);
+          attachRefIssueContextPopup(refIssues);
         }
         const $content = $segment;
         if (!$content.find('.dropzone-attachments').length) {