Skip to content

Commit 376c0e2

Browse files
authored
Remove fomantic transition module (#26469)
Removes all dropdown and dimmer animations. Works everywhere as far as I can tell, but need to give this thorough testing. Removes around 70kb JS/CSS. Note, I'm not 100% sure regarding the various callbacks, those will need more investigation, but it appears to work nonetheless. Fixes: #15709
1 parent 3b129aa commit 376c0e2

File tree

7 files changed

+72
-3177
lines changed

7 files changed

+72
-3177
lines changed

web_src/css/base.css

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
--color-button: #fafafa;
226226
--color-code-bg: #ffffff;
227227
--color-code-sidebar-bg: #f5f5f5;
228-
--color-shadow: #00000030;
228+
--color-shadow: #00000026;
229229
--color-secondary-bg: #f4f4f4;
230230
--color-expand-button: #d8efff;
231231
--color-placeholder-text: #aaa;
@@ -248,6 +248,7 @@
248248
--color-accent: var(--color-primary-light-1);
249249
--color-small-accent: var(--color-primary-light-6);
250250
--color-active-line: #fffbdd;
251+
--color-overlay-backdrop: #080808c0;
251252
accent-color: var(--color-accent);
252253
color-scheme: light;
253254
}
@@ -705,6 +706,16 @@ a.label,
705706
background: var(--color-active) !important;
706707
}
707708

709+
/* styles from removed fomantic transition module */
710+
.hidden.transition {
711+
visibility: hidden;
712+
display: none;
713+
}
714+
.visible.transition {
715+
display: block !important;
716+
visibility: visible !important;
717+
}
718+
708719
.ui.message {
709720
background: var(--color-box-body);
710721
color: var(--color-text);
@@ -796,7 +807,7 @@ a.label,
796807
.ui.selection.active.dropdown:hover,
797808
.ui.selection.active.dropdown .menu,
798809
.ui.selection.active.dropdown:hover .menu {
799-
border-color: var(--color-primary-light-2);
810+
border-color: var(--color-primary);
800811
}
801812

802813
.ui.selection.dropdown .menu {
@@ -1186,6 +1197,20 @@ img.ui.avatar,
11861197
box-shadow: none;
11871198
}
11881199

1200+
.ui.dropdown .menu,
1201+
.ui.upward.dropdown > .menu,
1202+
.ui.menu .dropdown.item .menu,
1203+
.ui.selection.active.dropdown .menu,
1204+
.ui.upward.selection.dropdown .menu,
1205+
.ui.selection.active.dropdown:hover .menu,
1206+
.ui.upward.active.selection.dropdown:hover .menu {
1207+
box-shadow: 0 6px 18px var(--color-shadow);
1208+
}
1209+
1210+
.ui.dimmer {
1211+
background: var(--color-overlay-backdrop);
1212+
}
1213+
11891214
/* Override semantic selector '.ui.menu:not(.vertical) .item > .button' */
11901215
/* This fixes the commit graph button on the commits page */
11911216
/* modal svg icons, copied from fomantic except width and height */

web_src/css/modules/animations.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,3 +105,9 @@ code.language-math.is-loading::after {
105105
.pulse {
106106
animation: pulse 2s linear;
107107
}
108+
109+
.ui.modal {
110+
animation-name: fadein;
111+
animation-duration: 300ms;
112+
animation-timing-function: ease-in-out;
113+
}

web_src/css/themes/theme-arc-green.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@
233233
--color-accent: var(--color-primary-light-1);
234234
--color-small-accent: var(--color-primary-light-5);
235235
--color-active-line: #534d1b;
236+
--color-overlay-backdrop: #080808c0;
236237
accent-color: var(--color-accent);
237238
color-scheme: dark;
238239
}

0 commit comments

Comments
 (0)