don't prompt interactively for clone credentials

noerw · noerw · commit 2d7da573dad8 · 2021-05-16T18:42:30.000+02:00
diff --git a/modules/git/repo.go b/modules/git/repo.go
@@ -147,7 +147,11 @@ func CloneWithArgs(ctx context.Context, from, to string, args []string, opts Clo
 		opts.Timeout = -1
 	}
 
-	_, err = cmd.RunTimeout(opts.Timeout)
+	env := []string{
+		"GIT_TERMINAL_PROMPT=0", // avoid prompting for credentials interactively, supported since git v2.3
+	}
+
+	_, err = cmd.RunInDirTimeoutEnv(env, opts.Timeout, "")
 	return err
 }
 

Original file line number	Diff line number	Diff line change
`@@ -147,7 +147,11 @@ func CloneWithArgs(ctx context.Context, from, to string, args []string, opts Clo`
`147`	`147`	`opts.Timeout = -1`
`148`	`148`	`}`
`149`	`149`
`150`		`- _, err = cmd.RunTimeout(opts.Timeout)`
	`150`	`+ env := []string{`
	`151`	`+ "GIT_TERMINAL_PROMPT=0", // avoid prompting for credentials interactively, supported since git v2.3`
	`152`	`+ }`
	`153`	`+`
	`154`	`+ _, err = cmd.RunInDirTimeoutEnv(env, opts.Timeout, "")`
`151`	`155`	`return err`
`152`	`156`	`}`
`153`	`157`