Fix duplicate migrated milestones (#30102)

yp05327 · web-flow · commit 274bc00ca2c3 · 2024-03-26T10:20:26.000Z
Fix #17567
diff --git a/services/migrations/migrate.go b/services/migrations/migrate.go
@@ -250,14 +250,13 @@ func migrateRepository(ctx context.Context, doer *user_model.User, downloader ba
 			}
 			log.Warn("migrating milestones is not supported, ignored")
 		}
-
 		msBatchSize := uploader.MaxBatchInsertSize("milestone")
 		for len(milestones) > 0 {
 			if len(milestones) < msBatchSize {
 				msBatchSize = len(milestones)
 			}
 
-			if err := uploader.CreateMilestones(milestones...); err != nil {
+			if err := uploader.CreateMilestones(milestones[:msBatchSize]...); err != nil {
 				return err
 			}
 			milestones = milestones[msBatchSize:]

Original file line number	Diff line number	Diff line change
`@@ -250,14 +250,13 @@ func migrateRepository(ctx context.Context, doer *user_model.User, downloader ba`
`250`	`250`	`}`
`251`	`251`	`log.Warn("migrating milestones is not supported, ignored")`
`252`	`252`	`}`
`253`		`-`
`254`	`253`	`msBatchSize := uploader.MaxBatchInsertSize("milestone")`
`255`	`254`	`for len(milestones) > 0 {`
`256`	`255`	`if len(milestones) < msBatchSize {`
`257`	`256`	`msBatchSize = len(milestones)`
`258`	`257`	`}`
`259`	`258`
`260`		`- if err := uploader.CreateMilestones(milestones...); err != nil {`
	`259`	`+ if err := uploader.CreateMilestones(milestones[:msBatchSize]...); err != nil {`
`261`	`260`	`return err`
`262`	`261`	`}`
`263`	`262`	`milestones = milestones[msBatchSize:]`