Skip to content

Commit 237df2f

Browse files
ethantkoeniglafriks
authored andcommitted
Fix legacy URL redirects (#3100) (#3106)
1 parent b9abcb3 commit 237df2f

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

integrations/links_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,10 @@ func TestRedirectsNoLogin(t *testing.T) {
4646
prepareTestEnv(t)
4747

4848
var redirects = map[string]string{
49-
"/user2/repo1/commits/master": "/user2/repo1/commits/branch/master",
50-
"/user2/repo1/src/master": "/user2/repo1/src/branch/master",
49+
"/user2/repo1/commits/master": "/user2/repo1/commits/branch/master",
50+
"/user2/repo1/src/master": "/user2/repo1/src/branch/master",
51+
"/user2/repo1/src/master/file.txt": "/user2/repo1/src/branch/master/file.txt",
52+
"/user2/repo1/src/master/directory/file.txt": "/user2/repo1/src/branch/master/directory/file.txt",
5153
}
5254
for link, redirectLink := range redirects {
5355
req := NewRequest(t, "GET", link)

modules/context/repo.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,11 @@ func RepoRefByType(refType RepoRefType) macaron.Handler {
618618

619619
if refType == RepoRefLegacy {
620620
// redirect from old URL scheme to new URL scheme
621-
ctx.Redirect(path.Join(setting.AppSubURL, strings.TrimSuffix(ctx.Req.URL.String(), ctx.Params("*")), ctx.Repo.BranchNameSubURL()))
621+
ctx.Redirect(path.Join(
622+
setting.AppSubURL,
623+
strings.TrimSuffix(ctx.Req.URL.String(), ctx.Params("*")),
624+
ctx.Repo.BranchNameSubURL(),
625+
ctx.Repo.TreePath))
622626
return
623627
}
624628
}

0 commit comments

Comments
 (0)