Skip to content

Commit 1b762fc

Browse files
silverwindlunnytechknowlogick
authored
Remove vendored copy of fomantic-dropdown (#15193)
jQuery 3.6.0 seems to have broke the dropdown focus handling (focus would get stuck on the dropdown) in this module which we have vendored on top of fomantic for accessibility improvements. Either downgrading jQuery to 3.5.1 or removing the vendor copy seems to resolve the issue and I opted for removing the copy because I think such changes should be done upstream and the removal also lightens the JS by 155kB before minify/gzip. Fixes: #15172 Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>
1 parent f5b6dc9 commit 1b762fc

File tree

3 files changed

+0
-4302
lines changed

3 files changed

+0
-4302
lines changed

.eslintrc

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ root: true
22
reportUnusedDisableDirectives: true
33

44
ignorePatterns:
5-
- /web_src/js/vendor
65
- /templates/base/head.tmpl
76
- /templates/repo/activity.tmpl
87
- /templates/repo/view_file.tmpl

web_src/js/index.js

-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import './publicpath.js';
55
import Vue from 'vue';
66
import {htmlEscape} from 'escape-goat';
77
import 'jquery.are-you-sure';
8-
import './vendor/semanticdropdown.js';
98

109
import initMigration from './features/migration.js';
1110
import initContextPopups from './features/contextpopup.js';

0 commit comments

Comments
 (0)