optimize if you can

Author: 6543

models/issue_reaction.go

@@ -48,8 +48,10 @@ func (opts *FindReactionsOptions) toConds() builder.Cond {
 }
 
 //FindReactions returns Reactions based
-func FindReactions(opts FindReactionsOptions) (ReactionList, error) {
-	return findReactions(x, opts)
+func FindReactions(comment *Comment) (ReactionList, error) {
+	return findReactions(x, FindReactionsOptions{
+		IssueID: comment.IssueID,
+		CommentID: comment.ID})
 }
 
 func findReactions(e Engine, opts FindReactionsOptions) (ReactionList, error) {

routers/api/v1/repo/issue_comment.go

@@ -428,11 +428,6 @@ func GetCommentReactions(ctx *context.APIContext, form api.CommentReactionList)
 	// responses:
 	//   "200":
 	//     "$ref": "#/responses/CommentReactions"
-	issue, err := models.GetIssueByIndex(ctx.Repo.Repository.ID, ctx.ParamsInt64(":index"))
-	if err != nil {
-		ctx.Error(500, "GetIssueByIndex", err)
-		return
-	}
 	comment, err := models.GetCommentByID(ctx.ParamsInt64(":id"))
 	if err != nil {
 		if models.IsErrCommentNotExist(err) {
@@ -443,7 +438,7 @@ func GetCommentReactions(ctx *context.APIContext, form api.CommentReactionList)
 		return
 	}
 
-	rl, err := models.FindReactions(models.FindReactionsOptions{IssueID: issue.ID, CommentID: comment.ID})
+	rl, err := models.FindReactions(comment)
 	if err != nil {
 		ctx.Error(500, "FindReactionsOptions", err)
 		return