Skip to content

Commit 1a2ae64

Browse files
authored
Fix checkbox field markup (#30666)
Fixes #30664. Previous use was not a supported way by fomantic and the misuse only became visible after the checkbox migration.
1 parent 2ee93ea commit 1a2ae64

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

templates/user/settings/applications_oauth2_edit_form.tmpl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,11 @@
4141
<label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label>
4242
<textarea name="redirect_uris" id="redirect-uris" required>{{StringUtils.Join .App.RedirectURIs "\n"}}</textarea>
4343
</div>
44-
<div class="field ui checkbox {{if .Err_ConfidentialClient}}error{{end}}">
45-
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
46-
<input type="checkbox" name="confidential_client" {{if .App.ConfidentialClient}}checked{{end}}>
44+
<div class="field {{if .Err_ConfidentialClient}}error{{end}}">
45+
<div class="ui checkbox">
46+
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
47+
<input type="checkbox" name="confidential_client" {{if .App.ConfidentialClient}}checked{{end}}>
48+
</div>
4749
</div>
4850
<button class="ui primary button">
4951
{{ctx.Locale.Tr "settings.save_application"}}

templates/user/settings/applications_oauth2_list.tmpl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,11 @@
6161
<label for="redirect-uris">{{ctx.Locale.Tr "settings.oauth2_redirect_uris"}}</label>
6262
<textarea name="redirect_uris" id="redirect-uris"></textarea>
6363
</div>
64-
<div class="field ui checkbox {{if .Err_ConfidentialClient}}error{{end}}">
65-
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
66-
<input type="checkbox" name="confidential_client" checked>
64+
<div class="field {{if .Err_ConfidentialClient}}error{{end}}">
65+
<div class="ui checkbox">
66+
<label>{{ctx.Locale.Tr "settings.oauth2_confidential_client"}}</label>
67+
<input type="checkbox" name="confidential_client" checked>
68+
</div>
6769
</div>
6870
<button class="ui primary button">
6971
{{ctx.Locale.Tr "settings.create_oauth2_application_button"}}

0 commit comments

Comments
 (0)