Log the error returned by exec.Wait

Mura Li · Mura Li · commit c62f66a85ff3 · 2017-04-08T17:26:19.000+08:00
diff --git a/command.go b/command.go
@@ -12,6 +12,8 @@ import (
 	"os/exec"
 	"strings"
 	"time"
+
+	"code.gitea.io/gitea/modules/log"
 )
 
 var (
@@ -70,8 +72,8 @@ func (c *Command) RunInDirTimeoutPipeline(timeout time.Duration, dir string, std
 		return err
 	}
 
-	if err := cmd.Wait(); err == nil {
-		return nil
+	if err := cmd.Wait(); err != nil {
+		log.Error("exec.Wait: %v", err)
 	}
 
 	return ctx.Err()

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@ import (`
`12`	`12`	`"os/exec"`
`13`	`13`	`"strings"`
`14`	`14`	`"time"`
	`15`	`+`
	`16`	`+ "code.gitea.io/gitea/modules/log"`
`15`	`17`	`)`
`16`	`18`
`17`	`19`	`var (`
`@@ -70,8 +72,8 @@ func (c *Command) RunInDirTimeoutPipeline(timeout time.Duration, dir string, std`
`70`	`72`	`return err`
`71`	`73`	`}`
`72`	`74`
`73`		`- if err := cmd.Wait(); err == nil {`
`74`		`- return nil`
	`75`	`+ if err := cmd.Wait(); err != nil {`
	`76`	`+ log.Error("exec.Wait: %v", err)`
`75`	`77`	`}`
`76`	`78`
`77`	`79`	`return ctx.Err()`