Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Commit ac69f9b

Browse files
committed
Use b.Fatal in benchmark tests
1 parent ec4446b commit ac69f9b

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

blob_test.go

+7-2
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ THE SOFTWARE.`
5151

5252
func Benchmark_Blob_Data(b *testing.B) {
5353
for i := 0; i < b.N; i++ {
54-
r, _ := testBlob.Data()
54+
r, err := testBlob.Data()
55+
if err != nil {
56+
b.Fatal(err)
57+
}
5558
ioutil.ReadAll(r)
5659
}
5760
}
@@ -60,6 +63,8 @@ func Benchmark_Blob_DataPipeline(b *testing.B) {
6063
stdout := new(bytes.Buffer)
6164
for i := 0; i < b.N; i++ {
6265
stdout.Reset()
63-
testBlob.DataPipeline(stdout, nil)
66+
if err := testBlob.DataPipeline(stdout, nil); err != nil {
67+
b.Fatal(err)
68+
}
6469
}
6570
}

tree_entry_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -42,21 +42,21 @@ func BenchmarkEntries_GetCommitsInfo(b *testing.B) {
4242
var commit *Commit
4343
var entries Entries
4444
if repoPath, err := setupGitRepo(benchmark.url, benchmark.name); err != nil {
45-
panic(err)
45+
b.Fatal(err)
4646
} else if repo, err := OpenRepository(repoPath); err != nil {
47-
panic(err)
47+
b.Fatal(err)
4848
} else if commit, err = repo.GetBranchCommit("master"); err != nil {
49-
panic(err)
49+
b.Fatal(err)
5050
} else if entries, err = commit.Tree.ListEntries(); err != nil {
51-
panic(err)
51+
b.Fatal(err)
5252
}
5353
entries.Sort()
5454
b.StartTimer()
5555
b.Run(benchmark.name, func(b *testing.B) {
5656
for i := 0; i < b.N; i++ {
5757
_, err := entries.GetCommitsInfo(commit, "")
5858
if err != nil {
59-
panic(err)
59+
b.Fatal(err)
6060
}
6161
}
6262
})

0 commit comments

Comments
 (0)