(refactor) avoid querying the repo multiple times when generating branch commands

Author: alexmaco

src/components/branchlist.rs

@@ -115,6 +115,9 @@ impl Component for BranchListComponent {
 				out.clear();
 			}
 
+			let selection_is_cur_branch =
+				self.selection_is_cur_branch();
+
 			out.push(CommandInfo::new(
 				strings::commands::scroll(&self.key_config),
 				true,
@@ -139,7 +142,7 @@ impl Component for BranchListComponent {
 				strings::commands::compare_with_head(
 					&self.key_config,
 				),
-				!self.selection_is_cur_branch(),
+				!selection_is_cur_branch,
 				true,
 			));
 
@@ -156,8 +159,7 @@ impl Component for BranchListComponent {
 				strings::commands::select_branch_popup(
 					&self.key_config,
 				),
-				!self.selection_is_cur_branch()
-					&& self.valid_selection(),
+				!selection_is_cur_branch && self.valid_selection(),
 				true,
 			));
 
@@ -173,23 +175,23 @@ impl Component for BranchListComponent {
 				strings::commands::delete_branch_popup(
 					&self.key_config,
 				),
-				!self.selection_is_cur_branch(),
+				!selection_is_cur_branch,
 				true,
 			));
 
 			out.push(CommandInfo::new(
 				strings::commands::merge_branch_popup(
 					&self.key_config,
 				),
-				!self.selection_is_cur_branch(),
+				!selection_is_cur_branch,
 				true,
 			));
 
 			out.push(CommandInfo::new(
 				strings::commands::branch_popup_rebase(
 					&self.key_config,
 				),
-				!self.selection_is_cur_branch(),
+				!selection_is_cur_branch,
 				true,
 			));