From 7853366867390dde9ae43bef839c21359e8be3c1 Mon Sep 17 00:00:00 2001
From: Brad Harris <bmharris@gmail.com>
Date: Fri, 24 Feb 2023 22:49:04 +0000
Subject: [PATCH 1/2] adjusting copy for better readability

---
 components/dashboard/src/onboarding/StepOrgInfo.tsx  | 10 +++++++---
 .../dashboard/src/onboarding/exploration-reasons.ts  |  4 ++--
 components/dashboard/src/onboarding/job-roles.ts     | 12 ++++++------
 components/dashboard/src/onboarding/signup-goals.ts  |  2 +-
 4 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/components/dashboard/src/onboarding/StepOrgInfo.tsx b/components/dashboard/src/onboarding/StepOrgInfo.tsx
index f9922424c5bcec..974e000831914f 100644
--- a/components/dashboard/src/onboarding/StepOrgInfo.tsx
+++ b/components/dashboard/src/onboarding/StepOrgInfo.tsx
@@ -169,7 +169,7 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => {
                 <TextInputField
                     value={jobRoleOther}
                     onChange={setJobRoleOther}
-                    placeholder="Please specify"
+                    placeholder="Please share (optional)"
                     hint={
                         jobRole === JOB_ROLE_OTHER
                             ? "Please select the role that best describes the type of work you'll use Gitpod for"
@@ -205,7 +205,7 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => {
                 ))}
             </CheckboxInputField>
 
-            <CheckboxInputField label="I'm signing up for Gitpod to...">
+            <CheckboxInputField label="I'm signing up for Gitpod for...">
                 {signupGoalsOptions.map((o) => (
                     <CheckboxInput
                         key={o.value}
@@ -224,7 +224,11 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => {
             </CheckboxInputField>
 
             {signupGoals.includes(SIGNUP_GOALS_OTHER) && (
-                <TextInputField value={signupGoalsOther} placeholder="Please specify" onChange={setSignupGoalsOther} />
+                <TextInputField
+                    value={signupGoalsOther}
+                    placeholder="Please share (optional)"
+                    onChange={setSignupGoalsOther}
+                />
             )}
         </OnboardingStep>
     );
diff --git a/components/dashboard/src/onboarding/exploration-reasons.ts b/components/dashboard/src/onboarding/exploration-reasons.ts
index ed315edcf8c19d..3858df1aab34d2 100644
--- a/components/dashboard/src/onboarding/exploration-reasons.ts
+++ b/components/dashboard/src/onboarding/exploration-reasons.ts
@@ -7,10 +7,10 @@
 export const getExplorationReasons = () => {
     return [
         { value: "explore-professional", label: "For work" },
-        { value: "explore-personal", label: "For personal projects, or open-source" },
+        { value: "explore-personal", label: "For personal projects or open-source" },
         {
             value: "replace-remote-dev",
-            label: "To replace remote/containerized development (VDI, VM based, Docker Desktop,...)",
+            label: "To replace remote/containerized development (VDI, VM, Docker Desktop)",
         },
     ];
 };
diff --git a/components/dashboard/src/onboarding/job-roles.ts b/components/dashboard/src/onboarding/job-roles.ts
index d3378b3494b5cc..56c27b10542143 100644
--- a/components/dashboard/src/onboarding/job-roles.ts
+++ b/components/dashboard/src/onboarding/job-roles.ts
@@ -9,13 +9,13 @@ export const JOB_ROLE_OTHER = "other";
 export const getJobRoleOptions = () => {
     return [
         { value: "", label: "Please select one" },
-        { value: "software-eng", label: "Software Engineer" },
+        { value: "software-eng", label: "Software Engineering" },
         { value: "data", label: "Data / Analytics" },
-        { value: "academics", label: "Academic (Student, Researcher)" },
-        { value: "enabling", label: "Enabling team (Platform, Developer Experience)" },
-        { value: "team-lead", label: "Team / Function Lead" },
+        { value: "academics", label: "Academia (Student, Researcher)" },
+        { value: "enabling", label: "Platform or Developer Experience" },
+        { value: "team-lead", label: "A Team or Function Lead role" },
         { value: "devrel", label: "DevRel" },
-        { value: "product-design", label: "Product (PM, Designer)" },
-        { value: JOB_ROLE_OTHER, label: "Other - please specify / prefer not to say" },
+        { value: "product-design", label: "Product" },
+        { value: JOB_ROLE_OTHER, label: "Other" },
     ];
 };
diff --git a/components/dashboard/src/onboarding/signup-goals.ts b/components/dashboard/src/onboarding/signup-goals.ts
index 2904ec5f35f5d5..497b352040f38a 100644
--- a/components/dashboard/src/onboarding/signup-goals.ts
+++ b/components/dashboard/src/onboarding/signup-goals.ts
@@ -12,6 +12,6 @@ export const getSignupGoalsOptions = () => {
         { value: "onboarding", label: "Faster onboarding" },
         { value: "powerful-resources", label: "More powerful dev resources" },
         { value: "security", label: "More secure dev process" },
-        { value: SIGNUP_GOALS_OTHER, label: "Other - please specify / prefer not to say" },
+        { value: SIGNUP_GOALS_OTHER, label: "Other" },
     ];
 };

From c4b306bd8387ccb6de0b3ec6978c407cfa280ec9 Mon Sep 17 00:00:00 2001
From: Brad Harris <bmharris@gmail.com>
Date: Mon, 27 Feb 2023 16:37:44 +0000
Subject: [PATCH 2/2] addressing some review feedback

---
 .../dashboard/src/onboarding/StepOrgInfo.tsx     | 16 +---------------
 components/dashboard/src/onboarding/job-roles.ts |  2 +-
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/components/dashboard/src/onboarding/StepOrgInfo.tsx b/components/dashboard/src/onboarding/StepOrgInfo.tsx
index 974e000831914f..602c381aa1d6f9 100644
--- a/components/dashboard/src/onboarding/StepOrgInfo.tsx
+++ b/components/dashboard/src/onboarding/StepOrgInfo.tsx
@@ -150,11 +150,6 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => {
                     }
                     setJobRole(val);
                 }}
-                hint={
-                    jobRole !== JOB_ROLE_OTHER
-                        ? "Please select the role that best describes the type of work you'll use Gitpod for"
-                        : ""
-                }
                 error={jobRoleError.message}
                 onBlur={jobRoleError.onBlur}
             >
@@ -166,16 +161,7 @@ export const StepOrgInfo: FC<Props> = ({ user, onComplete }) => {
             </SelectInputField>
 
             {jobRole === JOB_ROLE_OTHER && (
-                <TextInputField
-                    value={jobRoleOther}
-                    onChange={setJobRoleOther}
-                    placeholder="Please share (optional)"
-                    hint={
-                        jobRole === JOB_ROLE_OTHER
-                            ? "Please select the role that best describes the type of work you'll use Gitpod for"
-                            : ""
-                    }
-                />
+                <TextInputField value={jobRoleOther} onChange={setJobRoleOther} placeholder="Please share (optional)" />
             )}
 
             <TextInputField
diff --git a/components/dashboard/src/onboarding/job-roles.ts b/components/dashboard/src/onboarding/job-roles.ts
index 56c27b10542143..0f3e2f1f883399 100644
--- a/components/dashboard/src/onboarding/job-roles.ts
+++ b/components/dashboard/src/onboarding/job-roles.ts
@@ -13,7 +13,7 @@ export const getJobRoleOptions = () => {
         { value: "data", label: "Data / Analytics" },
         { value: "academics", label: "Academia (Student, Researcher)" },
         { value: "enabling", label: "Platform or Developer Experience" },
-        { value: "team-lead", label: "A Team or Function Lead role" },
+        { value: "team-lead", label: "A Team Lead or Function Lead role" },
         { value: "devrel", label: "DevRel" },
         { value: "product-design", label: "Product" },
         { value: JOB_ROLE_OTHER, label: "Other" },