From 031cfabe19204555db87cff7a7ffb5c7a4b077cc Mon Sep 17 00:00:00 2001 From: Victor Nogueira Date: Mon, 17 Oct 2022 08:59:09 +0000 Subject: [PATCH] Update also the "pluginSinceBuild" Gradle property when updating JetBrains Plugins via GitHub Action --- .../jetbrains-update-plugin-platform-template.yml | 14 +++++++++----- .github/workflows/jetbrains-updates-template.yml | 3 ++- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.github/workflows/jetbrains-update-plugin-platform-template.yml b/.github/workflows/jetbrains-update-plugin-platform-template.yml index 14a1eae25dc625..1b987ba603cfe0 100644 --- a/.github/workflows/jetbrains-update-plugin-platform-template.yml +++ b/.github/workflows/jetbrains-update-plugin-platform-template.yml @@ -62,6 +62,8 @@ jobs: - name: Update ${{ inputs.gradlePropertiesPath }} if: ${{ steps.latest-version.outputs.result != steps.current-version.outputs.result }} run: | + PLUGIN_SINCE_BUILD=$(echo "${{ steps.latest-version.outputs.result }}" | sed 's/-EAP-CANDIDATE-SNAPSHOT//' | sed 's/-CUSTOM-SNAPSHOT//') + sed -i "s/pluginSinceBuild=.*/pluginSinceBuild=$PLUGIN_SINCE_BUILD/" ${{ inputs.gradlePropertiesPath }} sed -i 's/platformVersion=${{ steps.current-version.outputs.result }}/platformVersion=${{ steps.latest-version.outputs.result }}/' ${{ inputs.gradlePropertiesPath }} git diff - name: Create Pull Request for Gateway Plugin @@ -90,7 +92,8 @@ jobs: commit-message: "Update Platform Version of ${{ inputs.pluginName }} to ${{ steps.latest-version.outputs.result }}" branch: "jetbrains/${{ inputs.pluginId }}-platform" labels: "team: IDE,editor: jetbrains" - team-reviewers: "engineering-ide" + # We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194 + # team-reviewers: "engineering-ide" - name: Create Pull Request for Backend Plugin if: ${{ inputs.pluginId == 'backend-plugin' && steps.latest-version.outputs.result != steps.current-version.outputs.result }} uses: peter-evans/create-pull-request@v4 @@ -119,7 +122,8 @@ jobs: commit-message: "Update Platform Version of ${{ inputs.pluginName }} to ${{ steps.latest-version.outputs.result }}" branch: "jetbrains/${{ inputs.pluginId }}-platform" labels: "team: IDE" - team-reviewers: "engineering-ide" + # We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194 + # team-reviewers: "engineering-ide" - name: Get previous job's status id: lastrun uses: filiptronicek/get-last-job-status@main @@ -127,6 +131,6 @@ jobs: if: ${{ (success() && steps.lastrun.outputs.status == 'failed') || failure() }} uses: rtCamp/action-slack-notify@v2 env: - SLACK_WEBHOOK: ${{ secrets.slackWebhook }} - SLACK_COLOR: ${{ job.status }} - SLACK_TITLE: ${{ inputs.productName }} + SLACK_WEBHOOK: ${{ secrets.slackWebhook }} + SLACK_COLOR: ${{ job.status }} + SLACK_TITLE: ${{ inputs.productName }} diff --git a/.github/workflows/jetbrains-updates-template.yml b/.github/workflows/jetbrains-updates-template.yml index 297d03db8ca9fb..e050ba4f58bf60 100644 --- a/.github/workflows/jetbrains-updates-template.yml +++ b/.github/workflows/jetbrains-updates-template.yml @@ -90,7 +90,8 @@ jobs: commit-message: "[${{ inputs.productId }}] Update IDE image to build version ${{ steps.latest-release.outputs.version }}" branch: "jetbrains/${{ inputs.productId }}-${{ steps.latest-release.outputs.version2 }}" labels: "team: IDE,editor: jetbrains" - team-reviewers: "engineering-ide" + # We can't use `team-reviewers` until we resolve https://github.com/gitpod-io/gitpod/issues/12194 + # team-reviewers: "engineering-ide" - name: Get previous job's status id: lastrun uses: filiptronicek/get-last-job-status@main