Skip to content

Consolidate primary action button labels on workspace start #9201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gtsiolis opened this issue Apr 8, 2022 · 5 comments
Open

Consolidate primary action button labels on workspace start #9201

gtsiolis opened this issue Apr 8, 2022 · 5 comments
Labels
feature: workspace start page meta: never-stale This issue can never become stale team: IDE type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Apr 8, 2022

Problem to solve

In #8783, we've consolidated the editor options by having a single array of options including the browser version of VS Code which is the default and fallback option as well as other options for desktop editors or IDEs like VS Code and JetBrains' IDEs.

  1. When using the latest release for VS Code, the primary action button label reads: Open in VS Code Insiders on Desktop
  2. When not using the latest release for IntelliJ IDEA, the primary action button label reads: Open in IntelliJ IDEA
  3. When using the latest release for IntelliJ IDEA, the primary action button label reads: Open in IntelliJ IDEA

Proposal

Following up the relevant discussions[1][2] from #8783, to resolve the inconsistency above but also provide a better button label that treats desktop editors as first-class citizens we could do rename the button labels with the following structure:

Open [[EDITOR]] [[LATEST_RELEASE]]

For example, we could have Open VS Code, Open VS Code Insiders, Open IntelliJ IDEA, Open IntelliJ IDEA EAP, etc.

Cc @mustard-mh @akosyakov @loujaybee

@gtsiolis gtsiolis added type: improvement Improves an existing feature or existing code team: IDE labels Apr 8, 2022
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 10, 2022
@mustard-mh
Copy link
Contributor

I thought this issue has been fixed in that PR #8783 with line https://github.com/gitpod-io/gitpod/pull/8783/files#diff-f7dcb26962daf6bfdfa64d5694b28c680f2c2832943a8c6e858ba10fa50c1491R28

Screenshot with stable IntelliJ

@mustard-mh
Copy link
Contributor

Following up the relevant discussions[1][2] from #8783, to resolve the inconsistency above but also provide a better button label that treats desktop editors as first-class citizens we could do rename the button labels with the following structure:

Open [[EDITOR]] [[LATEST_RELEASE]]

For example, we could have Open VS Code, Open VS Code Insiders, Open IntelliJ IDEA, Open IntelliJ IDEA EAP, etc.

Not sure if we are going with it, since we have alert to notify users that the current IDE is latest/unstable below.

Feel free to reopen it

@gtsiolis
Copy link
Contributor Author

Thanks, @mustard-mh! This issue is mostly about label button structure as well as slightly related to #9883 (Cc @ghuntley @loujaybee), #8464 (Cc @filiptronicek @felladrin), and #6910.

To better visualize the issue here, let me add below two screenshots of the button when using VS Code (Desktop) and IntelliJ on the page which is shown only when a desktop editor option has been selected.

Using VS Code (Desktop) Using IntelliJ
Screenshot 2022-07-11 at 11 32 44 AM Screenshot 2022-07-11 at 11 33 36 AM

@gtsiolis gtsiolis reopened this Jul 11, 2022
@gtsiolis gtsiolis removed the meta: stale This issue/PR is stale and will be closed soon label Jul 11, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@mustard-mh mustard-mh added the meta: never-stale This issue can never become stale label Nov 9, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: workspace start page meta: never-stale This issue can never become stale team: IDE type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

No branches or pull requests

3 participants