-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Consolidate primary action button labels on workspace start #9201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I thought this issue has been fixed in that PR #8783 with line https://github.com/gitpod-io/gitpod/pull/8783/files#diff-f7dcb26962daf6bfdfa64d5694b28c680f2c2832943a8c6e858ba10fa50c1491R28
|
Not sure if we are going with it, since we have Feel free to reopen it |
Thanks, @mustard-mh! This issue is mostly about label button structure as well as slightly related to #9883 (Cc @ghuntley @loujaybee), #8464 (Cc @filiptronicek @felladrin), and #6910. To better visualize the issue here, let me add below two screenshots of the button when using VS Code (Desktop) and IntelliJ on the page which is shown only when a desktop editor option has been selected.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Problem to solve
In #8783, we've consolidated the editor options by having a single array of options including the browser version of VS Code which is the default and fallback option as well as other options for desktop editors or IDEs like VS Code and JetBrains' IDEs.
Proposal
Following up the relevant discussions[1][2] from #8783, to resolve the inconsistency above but also provide a better button label that treats desktop editors as first-class citizens we could do rename the button labels with the following structure:
For example, we could have Open VS Code, Open VS Code Insiders, Open IntelliJ IDEA, Open IntelliJ IDEA EAP, etc.
Cc @mustard-mh @akosyakov @loujaybee
The text was updated successfully, but these errors were encountered: