Skip to content

Add default redactor for the secrets #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #8840 ...
mrsimonemms opened this issue Mar 17, 2022 · 2 comments
Closed
Tracked by #8840 ...

Add default redactor for the secrets #8861

mrsimonemms opened this issue Mar 17, 2022 · 2 comments
Labels
meta: stale This issue/PR is stale and will be closed soon team: delivery Issue belongs to the self-hosted team

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Mar 17, 2022

Normally, we're only interested that the key/value pair is present and not empty. The values mean little to us.

See docs

@mrsimonemms mrsimonemms changed the title Can we add a redactor for secrets? Normally, we're only interested that the key/value pair is present and not empty. The values mean little to us. Add default redactor for the secrets Mar 17, 2022
@mrsimonemms mrsimonemms added the team: delivery Issue belongs to the self-hosted team label Mar 17, 2022
@stale
Copy link

stale bot commented Jun 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 19, 2022
@mrsimonemms
Copy link
Contributor Author

I don't think we need to do anything on this. We only store sensitive data in secrets and KOTS handles that by redacting it (see below)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: stale This issue/PR is stale and will be closed soon team: delivery Issue belongs to the self-hosted team
Projects
None yet
Development

No branches or pull requests

1 participant