Skip to content

Project settings navigation does not highlight active menu for previously added projects #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gtsiolis opened this issue Dec 14, 2021 · 2 comments · Fixed by #7259
Closed

Project settings navigation does not highlight active menu for previously added projects #7231

gtsiolis opened this issue Dec 14, 2021 · 2 comments · Fixed by #7259
Assignees
@jankeromnes
Labels
component: dashboard groundwork: awaiting deployment team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 14, 2021 •
edited
Loading

Bug description

Problem to solve

Before the fix in #6376 (Cc @laushinka) users were able to import projects from GitLab using the full-text name as the slug, see relevant comment in #5847 (comment).

See also #6723 (Cc @jankeromnes) in case this is relevant, too.

After the recent changes in #7031, the project settings navigation seems to break for those projects added before the slug fix mentioned above.

Project settings before the slug fix Project settings after the slug fix
Screenshot 2021-12-14 at 1 31 01 PM Screenshot 2021-12-14 at 1 31 26 PM

Proposal

TBD (To be discussed)

Steps to reproduce

Go to projects settings for a GitLab project added before the slug fix in #6376 and potentially #6723 that used to have a project name with empty characters in it.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response
@gtsiolis gtsiolis added type: bug Something isn't working component: dashboard team: webapp Issue belongs to the WebApp team labels Dec 14, 2021
@gtsiolis gtsiolis mentioned this issue Dec 15, 2021
Closed
@jankeromnes jankeromnes mentioned this issue Dec 15, 2021
Merged
@jankeromnes
Copy link
Contributor

/schedule

@jankeromnes
Copy link
Contributor

/assign

@roboquat roboquat moved this to Done in 🍎 WebApp Team Dec 16, 2021
@jldec jldec removed this from 🍎 WebApp Team Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankeromnes jankeromnes

Labels
component: dashboard groundwork: awaiting deployment team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dashboard] Fix PageWithSubMenu selection state by URL-encoding all links gitpod-io/gitpod
3 participants
@gtsiolis @jankeromnes @roboquat