Skip to content

[teams and projects] Use Git host repository IDs instead of their repo names/slugs #6060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ajhalili2006 opened this issue Oct 6, 2021 · 4 comments
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code user experience

Comments

@ajhalili2006
Copy link

ajhalili2006 commented Oct 6, 2021

About this Issue

The current form of URLs for projects may break if there are two repos with same name (but on different namespaces/orgs), similar to this one below:

<!-- a lot of URL encoded stuff for GitLab repos on teams -->
https://gitpod.io/t/recaptime-dev/Custom%20Docker%20Images%20for%20CI%20and%20CD

Instead, project URLs in Gitpod should be in form of https://gitpod-host.here.tld/projects/git{hub,lab}/repo-id, where:

  • git{hub,lab} - is the Git provider configured by the instance admin (currently instance admins cannot add more than one GitLab instances to use yet)
  • repo-id - is the repository ID (or in the case of GitLab, project ID) from the API requests during project addition
@jankeromnes
Copy link
Contributor

Many thanks for the helpful feedback!

  • Relatedly, we're currently discussing using GitLab's project URL slugs instead of full-text name in URLs: Project URL is not slugified for GitLab repos #5847

  • I agree that there should also be a de-duplication check (e.g. to append a -1 to the slug if the new slug already exists in your Team -- we even had that because we added two projects called "Gitpod" from different orgs 🙄 made it impossible to use one of them until we removed the other)

@jankeromnes jankeromnes added feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. type: improvement Improves an existing feature or existing code user experience labels Oct 6, 2021
@stale
Copy link

stale bot commented Feb 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Feb 24, 2022
@ajhalili2006
Copy link
Author

It's still in the backlog, I'm just bumping to ensure stale[bot] doesn't distrub again.

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Feb 24, 2022
@stale
Copy link

stale bot commented May 25, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 25, 2022
@stale stale bot closed this as completed Jun 29, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: stale This issue/PR is stale and will be closed soon type: improvement Improves an existing feature or existing code user experience
Projects
Archived in project
Development

No branches or pull requests

3 participants