Skip to content

Fix alerting on Stripe webhook failures #15202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14969 ...
jldec opened this issue Dec 7, 2022 · 5 comments · Fixed by #15953
Closed
Tracked by #14969 ...

Fix alerting on Stripe webhook failures #15202

jldec opened this issue Dec 7, 2022 · 5 comments · Fixed by #15953
Assignees
Labels
priority: must have This issue must be fixed before others - use sparingly team: webapp Issue belongs to the WebApp team

Comments

@jldec
Copy link
Contributor

jldec commented Dec 7, 2022

We are not getting alerts for Stripe webhook failures.
E.g. See slack thread (internal)
and another one (internal)

@jldec jldec added the team: webapp Issue belongs to the WebApp team label Dec 7, 2022
@jldec jldec moved this to Scheduled in 🍎 WebApp Team Dec 7, 2022
@jldec jldec added the priority: must have This issue must be fixed before others - use sparingly label Dec 7, 2022
@easyCZ
Copy link
Member

easyCZ commented Dec 7, 2022

The alert which should be firing for this is defined here.

The query used in the alert, displayed in grafana is here. From this, the alert should've fired.

@easyCZ
Copy link
Member

easyCZ commented Dec 7, 2022

But from the alerts log, it hasn't.

@jldec jldec changed the title Improve alerting on Stripe webhook failures Fix alerting on Stripe webhook failures Dec 10, 2022
@jldec
Copy link
Contributor Author

jldec commented Dec 27, 2022

@easyCZ how can we test alerting on Stripe webhook failures?
Is there a way to inject failures in dev-mode and confirm that the alerts are triggered>

@easyCZ
Copy link
Member

easyCZ commented Jan 20, 2023

The webhook is sent against our API. So we can mimic the webhook by sending such a payload. We will likely need to craft the payload carefully as there is signature validation but should be doable, in theory.

@easyCZ easyCZ self-assigned this Jan 23, 2023
@easyCZ easyCZ moved this from Scheduled to In Progress in 🍎 WebApp Team Jan 23, 2023
@easyCZ easyCZ moved this from In Progress to In Validation in 🍎 WebApp Team Jan 23, 2023
@easyCZ easyCZ moved this from In Validation to Done in 🍎 WebApp Team Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: must have This issue must be fixed before others - use sparingly team: webapp Issue belongs to the WebApp team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants