Skip to content

Change the Installer customisation to not update the selector labels #11952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #9926
mrsimonemms opened this issue Aug 8, 2022 · 0 comments · Fixed by #11954
Closed
Tracked by #9926

Change the Installer customisation to not update the selector labels #11952

mrsimonemms opened this issue Aug 8, 2022 · 0 comments · Fixed by #11954
Assignees

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Aug 8, 2022

We recently added the ability to add custom labels, annotations and envvars to pods. For simplicity, this was added to the selector labels as well. As these are immutable, this was a mistake in retrospect.

The selectorLabels should be amended so that they only have the default labels adding, not the custom labels

This is blocking #9926 as this requires custom labels adding to the pods so that they are picked up for backup.

IMPORTANT This will introduce a potentially breaking change to the next release of Gitpod which we will need to document @lucasvaltl. The fix is as per the website. However, by doing this change, it removes this limitation for future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant