Skip to content

allow image-builder-mk3 to have multiple pull secrets #10396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #10298
mrsimonemms opened this issue Jun 1, 2022 · 2 comments
Closed
Tracked by #10298

allow image-builder-mk3 to have multiple pull secrets #10396

mrsimonemms opened this issue Jun 1, 2022 · 2 comments
Labels
component: image-builder meta: stale This issue/PR is stale and will be closed soon team: workspace Issue belongs to the Workspace team

Comments

@mrsimonemms
Copy link
Contributor

mrsimonemms commented Jun 1, 2022

For a full explanation of the problem, see this comment in 10298

The image-builder-mk3 requires support for multiple pull secrets to maintain parity with the imagePullSecrets in Kubernetes's pod spec.

Suggested approach

  • add in pullSecrets as an array of strings (can remove pullSecret in a future PR, but out of scope for this ticket)
  • usage of these pullSecrets then becomes "loop through the secrets, only failing when all have failed"
@atduarte
Copy link
Contributor

@kylos101 how much effort would you say this is?

@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@stale stale bot closed this as completed Nov 26, 2022
@stale stale bot moved this to Awaiting Deployment in 🌌 Workspace Team Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: image-builder meta: stale This issue/PR is stale and will be closed soon team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants