[ws-manager] fix finalizeWorkspaceContent can be called twice

sagor999 · roboquat · commit fbbec7b307db · 2022-04-28T09:47:14.000+05:30
diff --git a/components/ws-manager/pkg/manager/monitor.go b/components/ws-manager/pkg/manager/monitor.go
@@ -376,8 +376,9 @@ func actOnPodEvent(ctx context.Context, m actingManager, status *api.WorkspaceSt
 		}
 
 		_, gone := wso.Pod.Annotations[wsk8s.ContainerIsGoneAnnotation]
+		_, alreadyFinalized := wso.Pod.Annotations[disposalStatusAnnotation]
 
-		if terminated || gone {
+		if (terminated || gone) && !alreadyFinalized {
 			// We start finalizing the workspace content only after the container is gone. This way we ensure there's
 			// no process modifying the workspace content as we create the backup.
 			go m.finalizeWorkspaceContent(ctx, wso)

Original file line number	Diff line number	Diff line change
`@@ -376,8 +376,9 @@ func actOnPodEvent(ctx context.Context, m actingManager, status *api.WorkspaceSt`
`376`	`376`	`}`
`377`	`377`
`378`	`378`	`_, gone := wso.Pod.Annotations[wsk8s.ContainerIsGoneAnnotation]`
	`379`	`+ _, alreadyFinalized := wso.Pod.Annotations[disposalStatusAnnotation]`
`379`	`380`
`380`		`- if terminated \|\| gone {`
	`381`	`+ if (terminated \|\| gone) && !alreadyFinalized {`
`381`	`382`	`// We start finalizing the workspace content only after the container is gone. This way we ensure there's`
`382`	`383`	`// no process modifying the workspace content as we create the backup.`
`383`	`384`	`go m.finalizeWorkspaceContent(ctx, wso)`