Skip to content

Commit f8e204b

Browse files
committed
[dashboard] display opening workspace when ide is not ready yet
1 parent 26f35e4 commit f8e204b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

components/dashboard/src/start/StartWorkspace.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export interface StartWorkspaceProps {
3838
* This flag is used to break the autostart-cycle explained in https://github.com/gitpod-io/gitpod/issues/8043
3939
*/
4040
dontAutostart: boolean;
41+
notFound: boolean;
4142
}
4243

4344
export function parseProps(workspaceId: string, search?: string): StartWorkspaceProps {
@@ -56,6 +57,7 @@ export function parseProps(workspaceId: string, search?: string): StartWorkspace
5657
// - we assume the workspace has already been started for us
5758
// - we don't know it's instanceId
5859
dontAutostart: params.notFound || runsInIFrame,
60+
notFound: params.notFound ?? false,
5961
};
6062
}
6163

@@ -432,12 +434,12 @@ export default class StartWorkspace extends React.Component<StartWorkspaceProps,
432434
if (!this.state.desktopIde) {
433435
phase = StartPhase.Running;
434436

435-
if (this.props.dontAutostart) {
437+
if (this.props.notFound) {
436438
// hide the progress bar, as we're already running
437439
phase = undefined;
438440
title = "Running";
439441

440-
// in case we dontAutostart the IDE we have to provide controls to do so
442+
// in case URL contain not_found we have to provide controls to do so
441443
statusMessage = (
442444
<div>
443445
<div className="flex space-x-3 items-center text-left rounded-xl m-auto px-4 h-16 w-72 mt-4 mb-2 bg-gray-100 dark:bg-gray-800">

0 commit comments

Comments
 (0)