[server] fix infinite init loop of dynamic providers

... which is caused by casing mismatch.

Author: AlexTugarev

components/gitpod-db/src/auth-provider-entry-db.ts

@@ -15,6 +15,9 @@ export interface AuthProviderEntryDB {
     delete(ap: AuthProviderEntry): Promise<void>;
 
     findAll(exceptOAuthRevisions?: string[]): Promise<AuthProviderEntry[]>;
+    /**
+     * `host`s contained in the result array are expected to be lower case.
+     */
     findAllHosts(): Promise<string[]>;
     findByHost(host: string): Promise<AuthProviderEntry | undefined>;
     findByUserId(userId: string): Promise<AuthProviderEntry[]>;

components/gitpod-db/src/auth-provider-entry.spec.db.ts

@@ -81,6 +81,16 @@ export class AuthProviderEntryDBSpec {
         expect(await this.db.findAll([ap1.oauthRevision!]), "findAll([ap1])").to.deep.equal([ap2]);
     }
 
+    @test public async findAllHosts() {
+        const ap1 = this.authProvider({ id: "1", oauthRevision: "rev1", host: "foo" });
+        const ap2 = this.authProvider({ id: "2", oauthRevision: "rev2", host: "BAR" });
+        await this.db.storeAuthProvider(ap1, false);
+        await this.db.storeAuthProvider(ap2, false);
+
+        const all = await this.db.findAllHosts();
+        expect(all, "findAllHosts([])").to.deep.equal(["foo", "bar"]);
+    }
+
     @test public async oauthRevision() {
         const ap = this.authProvider({ id: "1" });
         await this.db.storeAuthProvider(ap, true);

components/gitpod-db/src/typeorm/auth-provider-entry-db-impl.ts

@@ -70,7 +70,8 @@ export class AuthProviderEntryDBImpl implements AuthProviderEntryDB {
         const repo = await this.getAuthProviderRepo();
         const query = repo.createQueryBuilder("auth_provider").select(hostField).where("auth_provider.deleted != true");
         const result = (await query.execute()) as Pick<DBAuthProviderEntry, "host">[];
-        return result.map((r) => r.host);
+        // HINT: host is expected to be lower case
+        return result.map((r) => r.host?.toLowerCase()).filter((h) => !!h);
     }
 
     async findByHost(host: string): Promise<AuthProviderEntry | undefined> {

components/server/src/auth/host-context-provider-impl.ts

@@ -112,10 +112,10 @@ export class HostContextProviderImpl implements HostContextProvider {
         // remove obsolete entries
         const currentHosts = new Set(await this.authProviderService.getAllAuthProviderHosts());
         ctx.span?.setTag("updateDynamicHosts.currentHostProviders", currentHosts.size);
+        // HINT: values of `currentHosts` are expected to be lower case
         const tobeRemoved = [...this.dynamicHosts.keys()].filter((h) => !currentHosts.has(h));
         for (const host of tobeRemoved) {
-            const hostContext = this.dynamicHosts.get(host);
-            log.debug("Disposing dynamic Auth Provider: " + host, { host, hostContext });
+            log.debug("Disposing dynamic Auth Provider: " + host);
 
             this.dynamicHosts.delete(host);
         }