[server] fix using snapshotBucketId when it is undefined or empty

sagor999 · roboquat · commit e67124fc807c · 2022-08-16T07:56:32.000+02:00
diff --git a/components/server/src/workspace/workspace-starter.ts b/components/server/src/workspace/workspace-starter.ts
@@ -1424,7 +1424,7 @@ export class WorkspaceStarter {
         }
 
         const volumeSnapshotId =
-            SnapshotContext.is(workspace.context) || WithPrebuild.is(workspace.context)
+            ((SnapshotContext.is(workspace.context) || WithPrebuild.is(workspace.context)) && workspace.context.snapshotBucketId !== undefined && workspace.context.snapshotBucketId != "")
                 ? workspace.context.snapshotBucketId
                 : lastValidWorkspaceInstanceId;
 

Original file line number	Diff line number	Diff line change
`@@ -1424,7 +1424,7 @@ export class WorkspaceStarter {`
`1424`	`1424`	`}`
`1425`	`1425`
`1426`	`1426`	`const volumeSnapshotId =`
`1427`		`- SnapshotContext.is(workspace.context) \|\| WithPrebuild.is(workspace.context)`
	`1427`	`+ ((SnapshotContext.is(workspace.context) \|\| WithPrebuild.is(workspace.context)) && workspace.context.snapshotBucketId !== undefined && workspace.context.snapshotBucketId != "")`
`1428`	`1428`	`? workspace.context.snapshotBucketId`
`1429`	`1429`	`: lastValidWorkspaceInstanceId;`
`1430`	`1430`